On Thu, Jan 27, 2011 at 6:05 AM, Joseph Kellermann <[email protected]> wrote: > Hi Marc, > > sorry for the confusion. > > The most important patch is for the erratum #89. I don't know why this patch > isn't included if 'CONFIG_K8_REV_F_SUPPORT == 1' . Linux Kernel 2.6.12 hangs > if errata#89 is not fixed, Kernel 2.6.26 doesn't. > I'll fix errata#89 and (errata#169 (in place of errata#131)) and (errata#254 > if TURION-S1G1), ok ? > Setting of F0x68[22:21] to 01b in 'k8_optimization()' , any idea for a better > place ? >
Hi Josef, I think it should all be done in k8_errata(); You probably need to pass the dev into the function. Marc > > ________________________________________ > Von: Marc Jones [[email protected]] > Gesendet: Donnerstag, 27. Januar 2011 00:45 > Bis: Joseph Kellermann > Cc: [email protected] > Betreff: Re: [coreboot] Errata #169 patch for Turion BH-G2 > > On Tue, Jan 25, 2011 at 8:16 AM, Joseph Kellermann > <[email protected]> wrote: >> This patch fixes a potential system hang (see 'Revision Guide for AMD NPT >> Family 0Fh Processors' 33610.pdf). >> >> Signed-off-by: Josef Kellermann <[email protected]> >> > > Hi Josef, > > Thanks for the patch. I have some questions. > > It looks like this patch mixed errata #131, #169, with #254. The rev > guide says to only implement #131 or #169, but there isn't a CPU > version decadency on either of those errata. The main part of your > patch, the S1G1 checking, looks like errata #254, which is not related > to #169 or #131. Can you confirm that? > > Marc > > -- > http://se-eng.com > > > ********************************************************************************************** > IMPORTANT NOTICE / WICHTIGER HINWEIS > This communication contains information which is confidential and may also be > privileged. It is for the > exclusive use of the intended recipient(s). If you are not the intended > recipient(s) please note that any > distribution, copying or use of this communication or the information in it > is strictly prohibited. If you have > received this communication in error please notify us immediately by email or > by telephone and then delete > this email and any copies of it. > Diese E-Mail koennte vertrauliche und/oder rechtlich geschuetzte > Informationen enthalten. Wenn Sie nicht > der richtige Adressat sind oder diese E-Mail irrtuemlich erhalten haben, > informieren Sie bitte sofort den > Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die > unbefugte Weitergabe dieser > Mail sind nicht gestattet. > > HEITEC AG, Werner-von-Siemens-Str. 61, 91052 Erlangen, HRB 7754, RG Fuerth, > Vorstandsvorsitzender: > Richard Heindl, Vorstand: Harald Preiml, Finanzvorstand: Rene-Oliver Rosner, > Aufsichtsratsvorsitzender: Dr. > Lorenz M. Raith, WWW: http://www.heitec.de > ********************************************************************************************** > > -- http://se-eng.com -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
