On 03.05.2011, at 06:04, Peter Stuge <[email protected]> wrote:

> repository service wrote:
>> +++ trunk/src/southbridge/intel/i82801gx/Kconfig    Tue May  3 09:55:30 2011 
>>    (r6553)
>> @@ -38,5 +38,10 @@
>>    int
>>    default 1 
>> 
>> +config BOOTBLOCK_SOUTHBRIDGE_INIT
>> +        string
>> +    default "southbridge/intel/i82801gx/bootblock.c"
>> +    depends on SOUTHBRIDGE_INTEL_I82801GX
>> +
> 
> Why in Kconfig and not a Makefile variable?
> 
> Oh and please always double-check the whitespace. (See "string")
> 
> 
> //Peter

I agree this belongs in the Makefiles.. Not sure why we chose to put it here 
but it might have required another makefile pass otherwise 



-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to