Stefan Reinauer ([email protected]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1778
-gerrit commit a64d9797152538ffbf5964e3a32b3048eb86b8aa Author: Stefan Reinauer <[email protected]> Date: Mon Oct 15 13:18:06 2012 -0700 Add spinlock to serialize Intel microcode updates Updating microcode on several threads in a core at once can be harmful. Hence add a spinlock to make sure that does not happen. Change-Id: I0c9526b6194202ae7ab5c66361fe04ce137372cc Signed-off-by: Stefan Reinauer <[email protected]> --- src/cpu/intel/microcode/microcode.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/cpu/intel/microcode/microcode.c b/src/cpu/intel/microcode/microcode.c index a4471ca..15d6513 100644 --- a/src/cpu/intel/microcode/microcode.c +++ b/src/cpu/intel/microcode/microcode.c @@ -28,12 +28,16 @@ #include <cpu/x86/msr.h> #include <cpu/intel/microcode.h> -#if CONFIG_CPU_MICROCODE_IN_CBFS #ifdef __PRE_RAM__ +#if CONFIG_CPU_MICROCODE_IN_CBFS #include <arch/cbfs.h> +#endif #else +#if CONFIG_CPU_MICROCODE_IN_CBFS #include <cbfs.h> #endif +#include <smp/spinlock.h> +DECLARE_SPIN_LOCK(microcode_lock) #endif struct microcode { @@ -112,6 +116,9 @@ void intel_update_microcode(const void *microcode_updates) printk(BIOS_DEBUG, "microcode: sig=0x%x pf=0x%x revision=0x%x\n", sig, pf, rev); #endif +#if !defined(__ROMCC__) && !defined(__PRE_RAM__) + spin_lock(µcode_lock); +#endif m = microcode_updates; for(c = microcode_updates; m->hdrver; m = (const struct microcode *)c) { @@ -142,6 +149,10 @@ void intel_update_microcode(const void *microcode_updates) c += 2048; } } + +#if !defined(__ROMCC__) && !defined(__PRE_RAM__) + spin_unlock(µcode_lock); +#endif } #if CONFIG_CPU_MICROCODE_IN_CBFS -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
