Julius Werner <[email protected]> writes: >> The error is fixed by commit >> 54fd92bc (util/cbfstool/lz4frame.c: Add comment to fall through). > > Looks like I'm too late for that commit, but in general, please do not > just hack around in the LZ4 files. That code was pulled in verbatim > from the upstream source -- if there are issues with it, please > instead send a patch to https://github.com/lz4/lz4 and resync our code > base to there once it has landed.
[1] Tried to update lz4 files but needed the same 'fix' for gcc7 (comment was 'pass-through' instead of 'fall-through'), so it was dropped in favor [2]. It looks like version 1.8.0 has the proper "falls trough" comment to make gcc7 happy... [1] https://review.coreboot.org/#/c/20011/ "util/cbfstool: Update lz4 to 1.7.5" [2] https://review.coreboot.org/#/c/20036/ "util/cbfstool/lz4frame.c: Add comment to fall through" Kind regards -- Arthur Heymans -- coreboot mailing list: [email protected] https://mail.coreboot.org/mailman/listinfo/coreboot
