Dear coreboot community, I have been trying to merge few mainboard for some time, however I find it difficult to get reviews (and lead it towards merging), despite fulfilling all requests like Documentation entry.
Example: https://review.coreboot.org/c/coreboot/+/30360/13#message-7720bf7ed3f447a878a3c0e2fdd0c956e7430c08 I have rebased it, added Documentation entry, however nobody touched it since I lastly updated it in November. Following the same convention I have updated a Protectli FW6 Kaby Lake board patch today: https://review.coreboot.org/c/coreboot/+/33839/ Probably this week I will also update another mainboard patch with documentation: https://review.coreboot.org/c/coreboot/+/32076 Are there any exit criteria which initial mainboard commit should fulfil to be considered good quality and complete? I have also added changes to MAINTAINERS file (for the FW6) to indicate that these patches will not become a piece of unused and unmaintained code. The first two patches are solid and all issues documented. All of them will receive an entry in MAINTAINERS file. I would very appreciate a little bit of your attention on them and possibly reviews. I especially need the Kaby Lake board, because 3mdeb will soon begin upstreaming changes to support Boot Guard and Protectli FW6 is our reference platform. I don't want the mainboard patches to be a burden or blocking any related efforts. So I kindly ask for a tiny bit of your time to have a look at these patches. Let's improve coreboot together and make it a competitive (and even better) replacement of proprietary BIOS solutions. With kind regards, -- Michał Żygowski Firmware Engineer https://3mdeb.com | @3mdeb_com _______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
