Pádraig Brady wrote: ... >>> Subject: [PATCH] readlink: A new program to print the resolved path >> >> s/readlink: A/realpath: a/ > > Oops I did that to avoid the commit hook rejecting the new prefix, > which is only catered for in the patch itself. > I forgot to do the final adjustment with `git commit --amend -n`.
Yes, we do need an override mechanism to tell the commit hook "shut up and do what I say!" >> "make check" failed with this: >> >> FAIL: misc/help-version (exit: 1) >> ================================= >> ... >> + args= >> + env realpath >> realpath: missing operand > > That didn't fail for me? > Hmm realpath wasn't in my list of built_programs. > The reason is I had a test/.built-programs file present. > That should probably be updated unconditionally? > Anyway I now see the failure after first doing a `make clean`. Actually it's a missing dependency. This should fix it. >From 325f98e3746e8677de7f0b5e742b8b11eb5a92b4 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Sat, 31 Dec 2011 11:56:40 +0100 Subject: [PATCH] tests: fix a missing-dependency problem MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * tests/check.mk (.built-programs): Depend on ../src/Makefile, so that when we add a program, this file is updated, and the new program is tested via misc/help-version. Spotted by Pádraig Brady. --- tests/check.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/check.mk b/tests/check.mk index 557d41a..78d2dd7 100644 --- a/tests/check.mk +++ b/tests/check.mk @@ -39,7 +39,7 @@ check: vc_exe_in_TESTS CLEANFILES = CLEANFILES += .built-programs check-am: .built-programs -.built-programs: +.built-programs: ../src/Makefile $(AM_V_GEN)(cd $(top_builddir)/src \ && MAKEFLAGS= $(MAKE) -s built_programs.list) \ > $@-t && mv $@-t $@ -- 1.7.8.1.391.g2c2ad
