On 12/08/2013 05:01 AM, Pádraig Brady wrote: > It's debatable whether we need to do this before this release, > but documenting of the default can happen in gnulib anyway > as we'll adjust coreutils (the only current user) on the > next gnulib update.
So we needed a gnulib update anyway to fix a build failure on platforms with only some of the crypto hash routines available in libcrypto (noticed on solaris). So I've pushed the attached for that and to fixup this configure --with-openssl help issue too. thanks, Pádraig.
>From 4f63f275a34089cd04588414d9073eb06901447e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= <[email protected]> Date: Mon, 9 Dec 2013 12:07:05 +0000 Subject: [PATCH] build: update gnulib and improve --with-openssl configure help * configure.ac: Use gl_SET_CRYPTO_CHECK_DEFAULT() to set the coreutils default for --with-openssl early, so that the help text can be provided in a standard and complete form. * gnulib: Update to incorporate a build fix on platforms with only some of md5 and sha* implemented by libcrypto. --- configure.ac | 12 ++---------- gnulib | 2 +- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 16b6c35..4a7fa9e 100644 --- a/configure.ac +++ b/configure.ac @@ -50,16 +50,8 @@ m4_syscmd([test "${GNULIB_POSIXCHECK+set}" = set]) m4_if(m4_sysval, [0], [], [dnl gl_ASSERT_NO_GNULIB_POSIXCHECK]) -dnl Enable use of libcrypto if available. -dnl Note we could do this as follows: -dnl AS_VAR_SET_IF([with_openssl], [], [with_openssl=optional]) -dnl However that would not document the coreutils adjusted default, -dnl so we add another --with-openssl description just to document that -AC_ARG_WITH([openssl], - [AC_HELP_STRING([--with-openssl], - [The coreutils default is: --with-openssl=optional])], - [], - [with_openssl=optional]) +dnl Enable use of libcrypto if available, and warn if not found +gl_SET_CRYPTO_CHECK_DEFAULT([optional]) AC_PROG_CC_STDC AM_PROG_CC_C_O diff --git a/gnulib b/gnulib index fba20d1..8b55100 160000 --- a/gnulib +++ b/gnulib @@ -1 +1 @@ -Subproject commit fba20d159fe191b9d67688738b7c31e769171aac +Subproject commit 8b5510050ddbf5bdee4a7cb89f8ee32e08aecd94 -- 1.7.7.6
