On 10/29/2014 03:41 PM, Pádraig Brady wrote: > * tests/tail-2/F-vs-missing.sh: Comment with the correct total delay. > * tests/tail-2/F-vs-rename.shi: Likewise. > * tests/tail-2/flush-initial.sh: Likewise. > * tests/tail-2/inotify-hash-abuse.sh: Likewise. > * tests/tail-2/pipe-f2.sh: Likewise. > * tests/misc/chroot-fail.sh: Initialize can_chroot_root in all cases.
Looks good. While looking at all uses of retry_delay_, I found that its return code is not evaluated in tests/du/move-dir-while-traversing.sh - it should read: - retry_delay_ nonempty .1 5 + retry_delay_ nonempty .1 5 || fail=1 A failure in another use during cleanup in tests/tail-2/F-vs-missing.sh does not have necessarily to be caught, but it would if we created a syntax-check for 'retry_delay_.*\|\|' ... Have a nice day, Berny
