On 10/29/2014 10:30 PM, Pádraig Brady wrote: > On 10/29/2014 09:07 PM, Bernhard Voelker wrote: >> While looking at all uses of retry_delay_, I found that its return >> code is not evaluated in tests/du/move-dir-while-traversing.sh - >> it should read: >> >> - retry_delay_ nonempty .1 5 >> + retry_delay_ nonempty .1 5 || fail=1 > > Good catch. Please push that patch.
Thanks, pushed: http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=02e281e1b2 >> A failure in another use during cleanup in tests/tail-2/F-vs-missing.sh >> does not have necessarily to be caught, but it would if we created a >> syntax-check for 'retry_delay_.*\|\|' ... > > A syntax check for this is probably overkill. > This case would probably be better served by replacing the > cleanup() and associated retry_delay_() with a `wait`. I don't think so: I've also seen these .nfs-ABC123 files lurking around on NFS even a few seconds after the process had terminated, and the directory couldn't be deleted. Have a nice day, Berny
