On Fri, Sep 9, 2016 at 1:47 PM, Jim Meyering <[email protected]> wrote: > On Fri, Sep 9, 2016 at 1:29 PM, Jim Meyering <[email protected]> wrote: >> On Thu, Sep 8, 2016 at 7:33 PM, Assaf Gordon <[email protected]> wrote: >>> On 09/08/2016 04:40 PM, Jim Meyering wrote: >>>> >>>> On Wed, Sep 7, 2016 at 10:17 PM, Assaf Gordon <[email protected]> >>>> wrote: >>>>> >>>>> $ make >>>>> [...] >>>>> make[2]: *** No rule to make target `lib/assert.h', needed by `all'. >>>>> Stop. >>> >>> >>>> I noticed the same failure on a Centos 7 system. >>>> I dug enough to find the probable cause+solution in the attached proposed >>>> patch: >>> >>> >>> Thanks! >>> >>> That fixed the build on Mac OS X. >> >> Thanks for checking. >> I was not satisfied with my knee-jerk fix, since I hadn't really >> understood the failure, ... so backed out my change locally on each >> system (centos and osx) and tried to reproduce, but now cannot >> reproduce it, anywhere. I even tried in a just-cloned repository. >> >> Assaf, would you please try to reproduce that failure in a just-cloned >> working directory? > > Actually, I've just reproduced it again, so I should be able to deal with it.
The real problem is that the getprogname module is using the assert-h module unnecessarily. That module is required only for C11-conformant static_assert, not for mere <assert.h>. Here's the patch for that (in gnulib) that I will push soon: P.S., There is still the issue that one should be able to use the assert-h module only from a gnulib-test in a partially non-recursive project like coreutils, but I will not pursue that one right now.
From 6d237fd01d98f2cdd588055a088fed39646ab82f Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Fri, 9 Sep 2016 15:46:53 -0700 Subject: [PATCH] getprogname-tests: don't depend on assert-h * modules/getprogname-tests (Depends-on): Remove assert-h. It was not needed, and in fact would cause build failure for coreutils on some systems. Reported by Assaf Gordon in https: //lists.gnu.org/archive/html/coreutils/2016-09/msg00016.html --- ChangeLog | 8 ++++++++ modules/getprogname-tests | 1 - 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index b7646ea..1278898 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2016-09-09 Jim Meyering <[email protected]> + + getprogname-tests: don't depend on assert-h + * modules/getprogname-tests (Depends-on): Remove assert-h. + It was not needed, and in fact would cause build failure for + coreutils on some systems. Reported by Assaf Gordon in https: + //lists.gnu.org/archive/html/coreutils/2016-09/msg00016.html + 2016-09-07 Jim Meyering <[email protected]> getprogname-tests: work also when EXEEXT is nonempty diff --git a/modules/getprogname-tests b/modules/getprogname-tests index 822b7a3..cbfda75 100644 --- a/modules/getprogname-tests +++ b/modules/getprogname-tests @@ -2,7 +2,6 @@ Files: tests/test-getprogname.c Depends-on: -assert-h string configure.ac: -- 2.7.4
