On Fri, Sep 9, 2016 at 3:51 PM, Jim Meyering <[email protected]> wrote: > On Fri, Sep 9, 2016 at 1:47 PM, Jim Meyering <[email protected]> wrote: >> On Fri, Sep 9, 2016 at 1:29 PM, Jim Meyering <[email protected]> wrote: >>> On Thu, Sep 8, 2016 at 7:33 PM, Assaf Gordon <[email protected]> wrote: >>>> On 09/08/2016 04:40 PM, Jim Meyering wrote: >>>>> >>>>> On Wed, Sep 7, 2016 at 10:17 PM, Assaf Gordon <[email protected]> >>>>> wrote: >>>>>> >>>>>> $ make >>>>>> [...] >>>>>> make[2]: *** No rule to make target `lib/assert.h', needed by `all'. >>>>>> Stop. >>>> >>>> >>>>> I noticed the same failure on a Centos 7 system. >>>>> I dug enough to find the probable cause+solution in the attached proposed >>>>> patch: >>>> >>>> >>>> Thanks! >>>> >>>> That fixed the build on Mac OS X. >>> >>> Thanks for checking. >>> I was not satisfied with my knee-jerk fix, since I hadn't really >>> understood the failure, ... so backed out my change locally on each >>> system (centos and osx) and tried to reproduce, but now cannot >>> reproduce it, anywhere. I even tried in a just-cloned repository. >>> >>> Assaf, would you please try to reproduce that failure in a just-cloned >>> working directory? >> >> Actually, I've just reproduced it again, so I should be able to deal with it. > > The real problem is that the getprogname module is using the assert-h > module unnecessarily. That module is required only for C11-conformant > static_assert, not for mere <assert.h>. > Here's the patch for that (in gnulib) that I will push soon: > > P.S., There is still the issue that one should be able to use the > assert-h module only from a gnulib-test in a partially non-recursive > project like coreutils, but I will not pursue that one right now.
I've pushed that to gnulib and pushed this gnulib-submodule-updating commit to coreutils to fix the build failure there:
From 677ae07083f41754fc9d3c7a0559248063908e30 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Fri, 9 Sep 2016 18:46:55 -0700 Subject: [PATCH] gnulib: update to latest, for getprogname fixes Compiling in gnulib-tests/ would fail on some platforms due to a missing lib/assert.h. Reported by Assaf Gordon in https://lists.gnu.org/archive/html/coreutils/2016-09/msg00016.html --- gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnulib b/gnulib index 7da1068..6d237fd 160000 --- a/gnulib +++ b/gnulib @@ -1 +1 @@ -Subproject commit 7da1068a87c331793af73359d8637d140d08a674 +Subproject commit 6d237fd01d98f2cdd588055a088fed39646ab82f -- 2.7.4
