On Sat, Oct 15, 2016 at 8:56 AM, Jim Meyering <j...@meyering.net> wrote:
> On Sat, Oct 15, 2016 at 8:40 AM, Jim Meyering <j...@meyering.net> wrote:
>> On Sat, Oct 15, 2016 at 2:55 AM, Pádraig Brady <p...@draigbrady.com> wrote:
>>> On 15/10/16 05:47, Jim Meyering wrote:
>>>> I tried to build the coreutils using very recent GCC 7, built from
>>>> latest git, and encountered a few new warnings (errors when configured
>>>> with --enable-gcc-warnings), so wrote the following to address them.
>>>> With these, everything now compiles warning free:
>>> All look good.
> Thanks for the review. Pushed.
That change was incomplete. Since die.h is not yet in a gnulib module,
we have to tell coreutils to distribute it, explicitly. I've just
pushed this fix:
From d035eacfdeba2da0134e606c8a63b2f3c0bd05bb Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyer...@fb.com>
Date: Sat, 15 Oct 2016 15:27:48 -0700
Subject: [PATCH] build: also distribute new file, src/die.h
* src/local.mk (noinst_HEADERS): Add die.h.
src/local.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/local.mk b/src/local.mk
index 6afaf83..a8d7866 100644
@@ -43,6 +43,7 @@ noinst_HEADERS = \
+ src/die.h \