On Wed, Nov 23, 2016 at 3:18 AM, Eric Blake <[email protected]> wrote: > On 11/23/2016 04:54 AM, Pádraig Brady wrote: >> On 23/11/16 05:36, Jim Meyering wrote: >>> diff --git a/src/local.mk b/src/local.mk >>> index 9e36ad9..37f625c 100644 >>> --- a/src/local.mk >>> +++ b/src/local.mk >>> @@ -644,3 +644,4 @@ else >>> cu_install_program = src/ginstall >>> endif >>> INSTALL_PROGRAM = $(cu_install_program) >>> +INSTALL = $(cu_install_program) -c >> >> Why the -c ? > > Because that's how automake usually defines INSTALL. Without the patch, > Makefile gets: > > INSTALL = /usr/bin/install -c > INSTALL_DATA = ${INSTALL} -m 644 > INSTALL_PROGRAM = ${INSTALL} > > But that argues that maybe $(cu_install_program) should include the -c, > or that our override of INSTALL_PROGRAM is unneeded if we only override > INSTALL.
That bothered me, too. I've confirmed that everything works with the more minimal change. Thank you, Eric. Thanks to Berny, too, for pointing out my log typo.
