On 11/1/25 23:37, Collin Funk wrote:
Bernhard Voelker <[email protected]> writes:
Two df(1) tests were skipped:
no-mtab-status.sh: skipped test: failed to build mntent shared library
SKIP: tests/df/no-mtab-status.sh
skip-duplicates.sh: skipped test: failed to build mntent shared library
SKIP: tests/df/skip-duplicates.sh
The attached patch fixes that build failure.
FWIW, but those 2 tests still get skipped - at least here on my
openSUSE:Tumbleweed system:
+ test -f x
+ skip_ 'internal test failure: maybe LD_PRELOAD doesn'\''t work?'
I noticed that the open() function is not called (anymore?),
but instead it would work again when substituting fopen().
See attached 'tests-df-LD_PRELOAD-fopen-not-open.diff' file.
Do you see the same?
Good catch. I see the same thing. Applying both of your patches fixes
it:
$ make check \
TESTS='tests/df/no-mtab-status.sh tests/df/skip-duplicates.sh'
PASS: tests/df/no-mtab-status.sh
PASS: tests/df/skip-duplicates.sh
Thanks for verifying.
But before pushing this second part, I'd rather like to understand why gnulib's
read_file_system_list now uses fopen instead of open again ... because this
would
contradicts Padraig's commit 6f1ec80f31164e from last year.
Have a nice day,
Berny
