On 03/11/2025 16:32, Bernhard Voelker wrote:
On 11/2/25 14:13, Pádraig Brady wrote:
On 01/11/2025 23:49, Bernhard Voelker wrote:
Thanks for verifying.
But before pushing this second part, I'd rather like to understand why gnulib's
read_file_system_list now uses fopen instead of open again ... because this
would
contradicts Padraig's commit 6f1ec80f31164e from last year.
I suspect gnulib is now using openat() rather than open().
If so we could adjust to wrap openat or fopen.
Since fopen is not replaced for me on glibc 2.41 (when it was on 2.39),
let's assume it's not replaced on current systems and go with both of your
patches.
That would explain it, I agree.
The attached patch #2 wraps both open and fopen, and performs the test here in
the
fopen code path successfully.
$ make check SUBDIRS=. TESTS="tests/df/no-mtab-status.sh
tests/df/skip-duplicates.sh"
...
PASS: tests/df/no-mtab-status.sh
PASS: tests/df/skip-duplicates.sh
@Padraig: does it work for you with open as well?
Okay to push both?
That's works here.
Please push.
thanks!
Padraig
