On 26/07/2026 04:37, Collin Funk wrote:
If you run this test on overlayfs, e.g., in a container, then it will
result in an ERROR. This is because 'tail' treats it as if it were
remote, which it may be, and does not use inotify.

I pushed it since it felt fairly obvious.

-- 8< --

* tests/tail/inotify-rotate-resources.sh: Also skip the test on
overlayfs.
---
  tests/tail/inotify-rotate-resources.sh | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/tests/tail/inotify-rotate-resources.sh 
b/tests/tail/inotify-rotate-resources.sh
index 066fdea30..8a3eed3bd 100755
--- a/tests/tail/inotify-rotate-resources.sh
+++ b/tests/tail/inotify-rotate-resources.sh
@@ -22,6 +22,11 @@ print_ver_ tail
  # Inotify not used on remote file systems
  require_local_dir_
+# We don't use inotify on overlayfs.
+# See the comments in human_fstype from src/stat.c.
+test "$(stat -f -c "%T" .)" != overlayfs \
+  || skip_ 'inotify is not used on overlayfs'
+
  grep '^#define HAVE_INOTIFY 1' "$CONFIG_HEADER" >/dev/null \
    || skip_ 'inotify required'

Oh it looks like this is another candidate to use
require_inotify_supported_ (tail --debug)?

https://github.com/coreutils/coreutils/commit/eebe2abbb

cheers,
Padraig

Reply via email to