Pádraig Brady <[email protected]> writes: > Oh it looks like this is another candidate to use > require_inotify_supported_ (tail --debug)? > > https://github.com/coreutils/coreutils/commit/eebe2abbb
Oh, I forgot about that function. Yes, it works and should be more robust. I pushed the attached patch. Thanks, Collin
>From ab6b01f40fbb5a755daa3352a0f14ca71b7a1103 Mon Sep 17 00:00:00 2001 Message-ID: <ab6b01f40fbb5a755daa3352a0f14ca71b7a1103.1785110160.git.collin.fu...@gmail.com> From: Collin Funk <[email protected]> Date: Sun, 26 Jul 2026 16:41:35 -0700 Subject: [PATCH] tests: prefer require_inotify_supported_ to file system check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * tests/tail/inotify-rotate-resources.sh: Use require_inotify_supported_ instead of require_local_dir_ and the recently added check for overlayfs. Suggested by Pádraig Brady. --- tests/tail/inotify-rotate-resources.sh | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tests/tail/inotify-rotate-resources.sh b/tests/tail/inotify-rotate-resources.sh index 8a3eed3bd..e1aeafbc2 100755 --- a/tests/tail/inotify-rotate-resources.sh +++ b/tests/tail/inotify-rotate-resources.sh @@ -19,13 +19,7 @@ . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src print_ver_ tail -# Inotify not used on remote file systems -require_local_dir_ - -# We don't use inotify on overlayfs. -# See the comments in human_fstype from src/stat.c. -test "$(stat -f -c "%T" .)" != overlayfs \ - || skip_ 'inotify is not used on overlayfs' +require_inotify_supported_ grep '^#define HAVE_INOTIFY 1' "$CONFIG_HEADER" >/dev/null \ || skip_ 'inotify required' -- 2.55.0
