On 27 Jul 2008, at 02:13, Andrew Mortensen wrote: > I noticed while testing a build from CVS head that mod_cosign causes > apache to dump core when httpd is shutting down. This was introduced > with the connection reordering patch. The culprit is a NULL > dereference in the child_exit handler:
I think this must depend on the way in which your Apache configuration is written. We've been running with the connection ordering patch for a while now without seeing segfaults. In particular, cfg->cl will only be NULL if you reach cosign_child_cleanup without having called set_cosign_host(). Essentially, this means that your configuration file doesn't contain the 'CosignService' directive at the server level. > In my testing, cfg->cl is always null here. We may be able to get away > without a handler at all, as it's only called when the child process > is exiting. Yes - I'm not sure what benefits this handler serves, given connections will be closed, and memory freed, when the process exits. It also never handled the case where cosign servers are defined outside the server level configuration. > The teardown_conn call isn't even used by the apache2 filter, though > that would change if we add checking for stale DNS to the filters. > I've heard someone from ed.ac.uk may have just such a patch. True? There is a patch at https://www.ease.ed.ac.uk/dist/mod_cosign.patch This isn't mine, and I can't comment on its copyright status. It's author is on this list though, so perhaps they can comment ... Cheers, Simon. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Cosign-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/cosign-discuss
