I noticed while testing a build from CVS head that mod_cosign causes
apache to dump core when httpd is shutting down. This was introduced
with the connection reordering patch. The culprit is a NULL
dereference in the child_exit handler:
static void
cosign_child_cleanup( server_rec *s, pool *p )
{
cosign_host_config *cfg;
/* upon child exit, close all open SNETs */
cfg = (cosign_host_config *) ap_get_module_config( s->module_config,
&cosign_module );
/* XXX segfault when cfg->cl == NULL */
if ( teardown_conn( *(cfg->cl), s ) != 0 ) {
cosign_log( APLOG_ERR, s, "mod_cosign: teardown conn err" );
}
return;
}
In my testing, cfg->cl is always null here. We may be able to get away
without a handler at all, as it's only called when the child process
is exiting.
The teardown_conn call isn't even used by the apache2 filter, though
that would change if we add checking for stale DNS to the filters.
I've heard someone from ed.ac.uk may have just such a patch. True?
andrew
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cosign-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cosign-discuss
