[EMAIL PROTECTED] writes:
Fixed. See the attachment.
------------------------------------------------------------------------
From Beijing, China
I reviewed this patch in greater detail. And I still think that this is not right:
- else if (strcmp(p, INBOX "." SENT) == 0)
+ else if (strcmp(p, INBOX "." SENT) == 0 || strcmp(path, SENT) == 0)
printf("%s", n_sent);
In your original message, you wrote yourself:
"Translate folder name like ".Sent.*" when form=folders."
But that's wrong. The only context where "Sent" carries a special meaning
is the top level Sent folder, INBOX.Sent. That's it. If there is some
folder named INBOX.Foo.Bar.Sent.Baz, substituting the translated name for
just the "Sent" part is wrong. Period.
Now, I understand that when you are displaying shared folders, some other mailbox's Sent folder will have a path other than INBOX.Sent, obviously, an thus not translated. That's certainly not 100% right, but this patch fixes it at the expense of breaking more stuff, and that's not the right solution.
I think that the right solution here is really to translate the actual folder names, instead of leaving the actual folder names as "Sent", "Drafts", and "Trash", and substituting their names on the fly.
That's going to be a much larger change, but that's going to be the correct solution. I'll put it on my list of things to do, but for now I'll leave things where they are, instead of making them even more convoluted.
pgp26XjgCsXUw.pgp
Description: PGP signature
_______________________________________________ courier-users mailing list [email protected] Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-users
