Hello,

It just took me some time to dig into an issue I had with courier on
Gentoo.

The problem was that certain executables like courieresmtpd were not
installed with the correct user/group settings.

I found that this line was the cause of the problem:
INSTALL=@INSTALL@ `test ! -w /etc || echo -o @mailuser@ -g @mailgroup@`

(in ./courier/module.esmtp/Makefile.am)

This tests if there's write access to /etc and decides that it can
chown then.

However, the Gentoo sandbox system, although running with root
permissions, prevents write access to /tmp.

So the correct way should be another test for root, e.g.
test `id -u` != 0

I've prepared a patch.
This is for both Makefile.in and Makefile.am to avoid the need for
autotools, however the first one gets generated automatically, only the
second one probably needs to be applied to courier.
Please note however that this fixes the issue ONLY for module.esmtp, although 
it seems to be
prevalent all over the couriere Makefile.am files. I wanted first to
discuss if this is the correct approach to fix it. If you're okay with
that, I'll send you further patches for the others.

-- 
Hanno Böck              mail/jabber: ha...@hboeck.de
GPG: BBB51E42           http://www.hboeck.de/
diff -u courier-0.68.1/courier/module.esmtp/Makefile.am courier-0.68.1-1/courier/module.esmtp/Makefile.am
--- courier-0.68.1/courier/module.esmtp/Makefile.am	2011-04-04 15:01:20.000000000 +0200
+++ courier-0.68.1-1/courier/module.esmtp/Makefile.am	2012-06-07 13:53:12.846012841 +0200
@@ -32,7 +32,7 @@
 	touch $@
 
 module_PROGRAMS=courieresmtp courieresmtpd addcr
-INSTALL=@INSTALL@ `test ! -w /etc || echo -o @mailuser@ -g @mailgroup@`
+INSTALL=@INSTALL@ `test `id -u` != 0 || echo -o @mailuser@ -g @mailgroup@`
 INSTALL_PROGRAM=${INSTALL} -m 550
 
 EXTRA_DIST=courier.config staticlist.c esmtp.authpam.dist esmtpd.cnf.gnutls
diff -u courier-0.68.1/courier/module.esmtp/Makefile.in courier-0.68.1-1/courier/module.esmtp/Makefile.in
--- courier-0.68.1/courier/module.esmtp/Makefile.in	2011-11-13 02:50:30.000000000 +0100
+++ courier-0.68.1-1/courier/module.esmtp/Makefile.in	2012-06-07 13:52:51.098284711 +0200
@@ -185,7 +185,7 @@
 EXEEXT = @EXEEXT@
 FGREP = @FGREP@
 GREP = @GREP@
-INSTALL = @INSTALL@ `test ! -w /etc || echo -o @mailuser@ -g @mailgroup@`
+INSTALL = @INSTALL@ `test \`id -u\` != 0 || echo -o @mailuser@ -g @mailgroup@`
 INSTALL_DATA = @INSTALL_DATA@
 INSTALL_PROGRAM = ${INSTALL} -m 550
 INSTALL_SCRIPT = @INSTALL_SCRIPT@

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
courier-users mailing list
courier-users@lists.sourceforge.net
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-users

Reply via email to