Autrijus Tang <[EMAIL PROTECTED]> writes: > On Fri, May 10, 2002 at 01:57:44PM -0500, Randy Kobes wrote: > > On Fri, 10 May 2002, Automated Perl Test Account wrote:
> > Although the existence of required modules can be checked for > > within Makefile.PL with the use of PREREQ_PM, not everyone uses > > this, or some do it in different ways, so it seems extreme to > > give this a failure based on Apache::AuthCookie not being > > previously installed. > > Yes, I agree a FAIL seems a little bit extreme. However, as PREREQ_PM > is the de facto way to specify dependencies, it would also be desirable > to notice the author, perhaps with a more encouraging message, e.g. > "hey, it looks like a PREREQ_PM would be nice. why not do that?". > > IIRC, that was also one of Michael Schwern's original ideas in CPANTS. > > > Perhaps CPANPLUS should be configured to automatically send > > only PASS reports, with the other grades needing human > > inspection before being sent? > > CPANPLUS currently only send FAIL reports that failed during the > 'make test' stage -- i.e. when the Makefile.PL thinks it's okay > to install this module, and after 'make' successfully executed without > problems. I think it's safe to say that, if the module has entered > that stage, it's unlikely that a 'make test' error would be a > false-negative. > > I'll try to find volunteers to hack the CPANPLUS::Internals::Report > to add the aforementioned "Can't locate" error detection, and methinks > it will be included in 0.04. But whether if it warrants a FAIL is open > to debate. Any thoughts? While at the moment these FAIL reports are quiet random -- meaning you get a FAIL if the user has not installed the used module, but a PASS if the user has installed it -- we had a discussion about exactly this topic a few month ago. The common consent on this list was to send FAIL reports if you catch such missing modules while runing "make test". IMHO, we should continue this reporting policy. For the modules author changing PREREQ_PM and uploading again is just a matter of a few minutes, while it makes all our lives as users much more easy. I have no idea how many of these FAIL reports -- where usually I talk about PREREQ_PM -- I have sent but I never got complaints, and most, if not all authors changed there Makefile.PL. Lets continue with these FAILS and educate the authors about PREREQ_PM. Andreas
