On Thu, 16 Jun 2011, Ask Bjørn Hansen wrote:
Date: Thu, 16 Jun 2011 11:51:49 -0700 From: Ask Bjørn Hansen <a...@perl.org> To: Henk P. Penning <he...@cs.uu.nl> Cc: cpan-workers@perl.org Subject: Re: new instant mirroring client
On Jun 16, 2011, at 1:03, Henk P. Penning wrote:
It's really great to get another client for the 'instant mirroring'
Hi Ask, thanks for looking at iim.
A couple of comments/questions: - Why skip some of the files from the (instant) mirror? Or am I reading the code wrong?
No files are skipped, all events are processed. Some updates aren't reported on in the log (by default) ; with '-v' all updates/deletes are logged, but it's tedious and real problems can be overlooked.
- The fake DBI.pm is a little dangerous in case someone tries to install it to the standard paths.
Agree, I'll get rid of it ; it's in a sub-part of Blib.pm that isn't used ; don't know how to fix that whithout cutting up Blib.pm.
- At a glance it looks like you just mirror one file at a time. If there are multiple new events, can't rsync mirror all of them in one connection/execution?
After sleeping, all new events are processed in one batch (one rsync connection). Finding the events (getting the RECENT-*.json files) happens 'one json at the time'. That could be improved, ideally 'one connection per loop-run', but it's a little tricky.
- ask
Groeten, HPP --------------------------------------------------------- _ Henk P. Penning, ICT-beta R Uithof WISK-412 _/ \_ Faculty of Science, Utrecht University T +31 30 253 4106 / \_/ \ Budapestlaan 6, 3584CD Utrecht, NL F +31 30 253 4553 \_/ \_/ http://people.cs.uu.nl/henkp/ M penn...@cs.uu.nl \_/
