On Wed, Jan 5, 2011 at 7:04 PM, Jude Brown <bookofj...@users.sourceforge.net> wrote: > commit 363d84146c1a0787a3ebf2c83b6dbc748569652c > Author: Jude Brown <bookofj...@users.sourceforge.net> > Date: Wed Jan 5 18:00:40 2011 +1000 > > Dump the monster enum comments. > > As with the previous commit, can be reverted if it is felt that the > monster number comments are necessary. They are almost always hideously > out of date, and as we refer to monster via "MONS_XXX" rather than "31", > unnecessary. > > As sorear has also pointed out: if we ever need to find the numeric > value of an enum, gdb provides this functionality. > > commit 8e670811def5a5a43f7383f1f90e5169e8383637 > Author: Jude Brown <bookofj...@users.sourceforge.net> > Date: Wed Jan 5 17:50:34 2011 +1000 > > Wrap MONS_UNUSED_XXX in #if-preprocessor blocks. > > We use this notation elsewhere in enum.h and enums in general to denote > sections or monsters that can be or have been disabled and should be > removed in the next major version. > > I think marking these now means that we can clean up the comments > (remove the numbering, which is bad and mostly misleading) and then > continue to add monsters to the end of the enum. > > Leaving space "so people can slot monsters in <here>" doesn't really > work because it doesn't seem to me that anyone really does this. Of > course, I could be wrong, so feel free to revert if it's felt that we > should keep this into major version 32.
Hopefully this change is to everyone's liking. It's possible that there is a uses for the UNUSED_MONSTERS/comments that I haven't foreseen, so if necessary, please revert. -Jude ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Crawl-ref-discuss mailing list Crawl-ref-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/crawl-ref-discuss
