On Wed, Jan 5, 2011 at 7:51 PM, Adam Borowski <kilob...@angband.pl> wrote: > On Wed, Jan 05, 2011 at 07:06:12PM +1000, Jude wrote: >> On Wed, Jan 5, 2011 at 7:04 PM, Jude Brown > Hell yeah! > I tried to do this almost a year ago, and was shouted at that they are > needed for debugging, even though:
Well, they haven't been maintained in the interim, so if they were previously used for debugging, it would appear they aren't currently; alternately, the people who used them may be currently inactive, etc. >> > As sorear has also pointed out: if we ever need to find the numeric >> > value of an enum, gdb provides this functionality. > > So many thanks for getting rid of this monstrosity. > >> > commit 8e670811def5a5a43f7383f1f90e5169e8383637 >> > Wrap MONS_UNUSED_XXX in #if-preprocessor blocks. > > Since there's a reason to bump the major[1], what about sorting the monsters > in some reasonable order? > >> > Leaving space "so people can slot monsters in <here>" doesn't really >> > work because it doesn't seem to me that anyone really does this. > > There is precisely one case where this matters: draconians. And it's not > likely that we're going to add new colours or classes -- and even if we do, > we can then make a minor shim or bump the major. Or go the old way and > leave a few blanks (with MONS_UNUSED, not =123 !). Ah, yes. I noticed them when scrolling down the list but didn't think of them when writing that. Sure, we could leave maybe three or four slots available. I don't honestly think we are that likely to add a lot of new draconian monsters. It's not like they're very weak or something. > [1]. If we do, it might be good to merge ench_split too -- there's a compat > shim but I don't fully understand Galehar's new skill training code so I'm > afraid of breaking it. We should start a major_bump_TODO file or something similar with a list of things that need to be done when bumping: 1. Ench split. 2. Elf size reduction. 3. Re-order the monsters. 4. I'm sure there's more stuff. -J ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Crawl-ref-discuss mailing list Crawl-ref-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/crawl-ref-discuss
