Review: Needs Fixing code review OK, I understand.
I'm seeing that these rules are already present in 6.1, but with different name, although the domain is the same for all. Your script has detected changes because there is a little diff between both versions with an ending comma. IMO you should fix one of these things: - Remove XML entry for rule domains, and let only name changes (and the change of one group). - Change it to not be multi-line to avoid ugly formatting inside OpenERP (or maybe incorrect behaviour). Regards. -- https://code.launchpad.net/~therp-nl/openupgrade-addons/7.0-project_data/+merge/216538 Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-addons. -- Mailing list: https://launchpad.net/~credativ Post to : [email protected] Unsubscribe : https://launchpad.net/~credativ More help : https://help.launchpad.net/ListHelp
