Well you are just never satisfied are you? :) Just kidding ... it is a good idea ... but, for the record, that "rather large comment block" was only 5 lines, consisting of only 250 characters. But, granted, that does triple the size of the minimum 130 character p2.index file. .... and when requested 500,000 times -- in one day! -- I can see how that'd add up (if everyone did it).
Besides fixing those files, I added a note to the wiki at http://wiki.eclipse.org/Equinox/p2/p2_index#Examples and opened two related bugs: Bug 373121 - p2 should use request headers accepting compression from server Bug 373122 - p2.index files should have no comments Thanks for helping us improve, From: Denis Roy <[email protected]> To: [email protected], Date: 03/02/2012 08:52 AM Subject: Re: [cross-project-issues-dev] p2 repositories ... we can do better Sent by: [email protected] David, Thanks for sending this out. I've noticed that on the release repos you've added a rather large comment block at the top of the file. This comment block gets transferred to each client that fetches the file. And since p2 doesn't ask for compressed content in its headers, the bytes go out full-sized. If the only purpose is to maintain some notes, I think a p2.index.readme file would be better, since it would not be transferred. Just a thought. Thanks, Denis On 03/02/2012 01:05 AM, David M Williams wrote: > > That is, we can do better at educating people how to make a good p2 > repository! We have not done that education well. Hopefully this note, with _______________________________________________ cross-project-issues-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev _______________________________________________ cross-project-issues-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
