I don't understand why the API tooling recommended a major increment since there was no breaking change — they were all API additions.
Given that it's been in place for 10 days, my vote is to recover from the mistake and fix the version number. Brian. > On 13-Mar-2017, at 6:07 AM, Simon Scholz <[email protected]> wrote: > > Hello, > > from my side I´ve just been following the checks of the API Base Line tooling > accroding to the changes in the generated code of the MUiFactory class. > So at least we should add the noimplement flag to the MUiFactory to avoid > further major version increments due to the missing noimplement flag. > But for now I think we should stick to the version increment to avoid > breaking clients who might have implemented MUiFactory, which anyways is > unlikely. > > Regards, > > Simon > > On Sat, Mar 11, 2017 at 6:09 PM, Ed Willink <[email protected] > <mailto:[email protected]>> wrote: > Hi > > Chaotic major versions seem undesirable, so since the major version has not > yet made it to +4 on any milestone it seems appropriate to revert it; > preferably for M6, but certainly for M7. > > We aggregate to find inconsistencies. We found one, the platform was wrong, > the platform should correct, not everyone else. > > Note that if the platform fails to revert, downstream projects that offer > multi-release compatibility must forever remember to specify an irregular > 1.0.0,3.0.0 range for this plugin. > > Note also that if PDE requires a major version change it usually means you > should revise your code to avoid the major version, not just throw a major > version to make the irritating error go away. > > Note also again that major version chnages should be announced so that > consumers and experts have an opportunity to comment in a more timely fashion. > Regards > > Ed Willink > > On 11/03/2017 16:52, Daniel Megert wrote: >> Thanks Tom! That was my thinking too. So, that class should be marked as >> @noimplement in the model, because next time, PDE Tools will again ask the >> developer to increment the major version. >> >> Unfortunately, at this point, reverting the major version increase seems to >> do more harm than having a few bundles adjust their dependency. If someone >> disagrees, please let us know asap. >> >> Dani >> >> >> >> From: Tom Schindl <[email protected]> >> <mailto:[email protected]> >> To: Cross project issues <[email protected]> >> <mailto:[email protected]> >> Date: 11.03.2017 17:35 >> Subject: Re: [cross-project-issues-dev] Problems with Simrel >> contribution re: org.eclipse.e4.ui.model.workbench >> Sent by: [email protected] >> <mailto:[email protected]> >> >> >> >> Under NO cricumstance this API is/has/should be implemented by clients! IIRC >> it should be called at by none e4 internals. So this version increase is >> just plain wrong! >> >> Tom (guy who was in charge of the model) >> >> Von meinem iPhone gesendet >> >> Am 11.03.2017 um 16:22 schrieb Daniel Megert <[email protected] >> <mailto:[email protected]>>: >> >> You're right Ed. At least in the SDK there's no re-export of that bundle. >> >> Dani >> >> >> >> From: Ed Willink <[email protected] <mailto:[email protected]>> >> To: [email protected] >> <mailto:[email protected]> >> Date: 11.03.2017 11:01 >> Subject: Re: [cross-project-issues-dev] Problems with Simrel >> contribution >> Sent by: [email protected] >> <mailto:[email protected]> >> >> >> >> Hi >> >> Correction. I misread the icons in the Plugin dependency view. Nothing >> in my workspace re-exports org.eclipse.e4.ui.model.workbench, so a major >> version change should be a simple MANIFEST.MF update for consumers. >> >> Regards >> >> Ed Willink >> >> On 11/03/2017 08:58, Ed Willink wrote: >> > Hi >> > >> > On the one hand, this looks like the normal excitement that occurs >> > when a plugin has a major version increase; every consumer must follow >> > suit on its dependency bounds. However it is surprising that no >> > announcement has been made, particularly so close to M6. >> > >> > On the other hand, there are many plugins that re-export >> > org.eclipse.e4.ui.model.workbench and so they too must also incur a >> > major version increment. org.eclipse.ui.ide is one of them and I doubt >> > we want a major version increment there. >> > >> > Presumably a typo then. I suggest nobody apart from the platform team >> > reacts. >> > >> > Regards >> > >> > Ed Willink >> > >> > On 11/03/2017 08:19, Eike Stepper wrote: >> >> Hi, >> >> >> >> It appears that https://git.eclipse.org/r/#/c/88492/ >> >> <https://git.eclipse.org/r/#/c/88492/>incremented the >> >> major version of the org.eclipse.e4.ui.model.workbench plugin. There >> >> are some other commits in the context of >> >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=484398 >> >> <https://bugs.eclipse.org/bugs/show_bug.cgi?id=484398>but none of them >> >> seems to justify a major version increment. Maybe I overlooked >> >> something historic that justifies it. Is it justifiable that the >> >> major version of this plugin was incremented, and if so, what is the >> >> justification? >> >> >> >> At this point it looks as if clients just need to increment their >> >> upper bound. >> >> >> >> Cheers >> >> /Eike >> >> >> >> ---- >> >> http://www.esc-net.de <http://www.esc-net.de/> >> >> http://thegordian.blogspot.com <http://thegordian.blogspot.com/> >> >> http://twitter.com/eikestepper <http://twitter.com/eikestepper> >> >> >> >> >> >> >> >> Am 11.03.2017 um 03:24 schrieb Evgeny Mandrikov: >> >>> Hello, >> >>> >> >>> I'm forwarding the following thread of discussion since seems that >> >>> previous messages were not delivered to the list - "being held until >> >>> the list moderator can review it for approval. The reason it is >> >>> being held: Too many recipients to the message" >> >>> >> >>> And an update on subject: >> >>> EclEmma has been re-enabled to unblock work of Andreas Sewe on >> >>> https://git.eclipse.org/r/#/c/84521/ >> >>> <https://git.eclipse.org/r/#/c/84521/> >> >>> Papyrus really seems to be a cause of a problem, because after >> >>> re-enablement all builds are still green. >> >>> >> >>> Regards, >> >>> Evgeny >> >>> >> >>> ---------- Forwarded message --------- >> >>> From: Evgeny Mandrikov <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>> >> >>> Date: Fri, Mar 10, 2017 at 1:46 PM >> >>> Subject: Re: Problems with Simrel contribution >> >>> To: Grégoire DUPE <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>>, Sravan >> >>> K Lakkimsetti >> >>> <[email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>>, >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>>>,[email protected] >> >>> <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>>>, [email protected] >> >>> <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>>, >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>>, >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>>, >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>>, >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>>>, >> >>> [email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>>>, [email protected] >> >>> <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>>, >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>>, >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>>, >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>> >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>>, >> >>> Frederic Gurr >> >>> <[email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>> >> >>> Cc: Cross project issues <[email protected] >> >>> <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>>> >> >>> >> >>> >> >>> Hi, >> >>> >> >>> FWIW I come to exactly the same conclusion. >> >>> And so tried to confirm by re-enabling EclEmma - >> >>> https://git.eclipse.org/r/#/c/92766/ >> >>> <https://git.eclipse.org/r/#/c/92766/>, validation build successful - >> >>> https://hudson.eclipse.org/simrel/job/simrel.oxygen.runaggregator.VALIDATE.gerrit/391/console >> >>> >> >>> <https://hudson.eclipse.org/simrel/job/simrel.oxygen.runaggregator.VALIDATE.gerrit/391/console> >> >>> >> >>> On Fri, Mar 10, 2017 at 1:24 PM Grégoire DUPE >> >>> <[email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>> wrote: >> >>> >> >>> Hello, >> >>> >> >>> It’s looks like that the problem comes from >> >>> ‘org.eclipse.papyrus.infra.widgets’ which has the following dependency >> >>> : org.eclipse.e4.ui.model.workbench [1.2.0,2.0.0) (cf. the error >> >>> message at the end of this e-mail) >> >>> >> >>> Can anybody from Papyrus check that ? >> >>> >> >>> Regards, >> >>> >> >>> Grégoire >> >>> >> >>> Cannot complete the install because of a conflicting dependency. >> >>> >> >>> Software being installed: validationSet_main 1.0.0 >> >>> >> >>> Only one of the following can be installed at once: >> >>> [org.eclipse.e4.ui.model.workbench 2.0.0.v20170228-1842, >> >>> org.eclipse.e4.ui.model.workbench 1.3.0.v20170105-1239] >> >>> >> >>> Cannot satisfy dependency: >> >>> mappedRepo_download.eclipse.org_eclipse_updates_4.7milestones_S-4.7M6-201703082000 >> >>> 1.0.0 depends on: org.eclipse.platform.ide 0.0.0 >> >>> >> >>> Cannot satisfy dependency: >> >>> mappedRepo_download.eclipse.org_modeling_mdt_papyrus_updates_milestones_3.0_M5_main >> >>> 1.0.0 depends on: org.eclipse.papyrus.sdk.feature.feature.group >> >>> 3.0.0 >> >>> >> >>> Cannot satisfy dependency: >> >>> org.eclipse.papyrus.infra.widget.feature.feature.group >> >>> 3.0.0.201702011724 depends on: >> >>> org.eclipse.papyrus.infra.widgets [3.0.0.201702011724] >> >>> >> >>> Cannot satisfy dependency: org.eclipse.papyrus.infra.widgets >> >>> 3.0.0.201702011724 depends on: bundle >> >>> org.eclipse.e4.ui.model.workbench [1.2.0,2.0.0) >> >>> >> >>> Cannot satisfy dependency: >> >>> org.eclipse.papyrus.sdk.feature.feature.group 3.0.0.201702011724 >> >>> depends on: >> >>> org.eclipse.papyrus.infra.widget.feature.feature.group >> >>> [3.0.0.201702011724] >> >>> >> >>> Cannot satisfy dependency: org.eclipse.platform.feature.group >> >>> 4.7.0.v20170308-2000 depends on: org.eclipse.ui.ide >> >>> [3.13.0.v20170306-1626] >> >>> >> >>> Cannot satisfy dependency: org.eclipse.platform.ide >> >>> 4.7.0.I20170308-2000 depends on: >> >>> org.eclipse.platform.feature.group [4.7.0.v20170308-2000] >> >>> >> >>> Cannot satisfy dependency: org.eclipse.ui.ide >> >>> 3.13.0.v20170306-1626 depends on: bundle >> >>> org.eclipse.e4.ui.model.workbench [2.0.0,3.0.0) >> >>> >> >>> Cannot satisfy dependency: validationSet_main 1.0.0 depends on: >> >>> mappedRepo_download.eclipse.org_eclipse_updates_4.7milestones_S-4.7M6-201703082000 >> >>> [1.0.0] >> >>> >> >>> Cannot satisfy dependency: validationSet_main 1.0.0 depends on: >> >>> mappedRepo_download.eclipse.org_modeling_mdt_papyrus_updates_milestones_3.0_M5_main >> >>> [1.0.0] >> >>> >> >>> Only one of the following can be installed at once: >> >>> >> >>> Eclipse Workbench Model 2.0.0.v20170228-1842 >> >>> (org.eclipse.e4.ui.model.workbench 2.0.0.v20170228-1842) >> >>> >> >>> Eclipse Workbench Model 1.3.0.v20170105-1239 >> >>> (org.eclipse.e4.ui.model.workbench 1.3.0.v20170105-1239) >> >>> >> >>> bundle(org.eclipse.e4.ui.model.workbench 2.0.0.v20170228-1842) >> >>> is required by: >> >>> >> >>> ValidationSet(main) >> >>> >> >>> Contribution(Eclipse) >> >>> >> >>> MappedRepository(http://download.eclipse.org/eclipse/updates/4.7milestones/S-4.7M6-201703082000/ >> >>> >> >>> <http://download.eclipse.org/eclipse/updates/4.7milestones/S-4.7M6-201703082000/>) >> >>> >> >>> >> >>> >> >>> Product(org.eclipse.platform.ide) >> >>> >> >>> InstallableUnit(org.eclipse.platform.feature.group >> >>> 4.7.0.v20170308-2000) >> >>> >> >>> InstallableUnit(org.eclipse.ui.ide 3.13.0.v20170306-1626) >> >>> >> >>> bundle(org.eclipse.e4.ui.model.workbench 1.3.0.v20170105-1239) >> >>> is required by: >> >>> >> >>> ValidationSet(main) >> >>> >> >>> Contribution(Papyrus) >> >>> >> >>> MappedRepository(http://download.eclipse.org/modeling/mdt/papyrus/updates/milestones/3.0/M5/main >> >>> >> >>> <http://download.eclipse.org/modeling/mdt/papyrus/updates/milestones/3.0/M5/main>) >> >>> >> >>> >> >>> >> >>> Feature(org.eclipse.papyrus.sdk.feature.feature.group 3.0.0) >> >>> >> >>> InstallableUnit(org.eclipse.papyrus.infra.widget.feature.feature.group >> >>> 3.0.0.201702011724) >> >>> >> >>> InstallableUnit(org.eclipse.papyrus.infra.widgets >> >>> 3.0.0.201702011724) >> >>> >> >>> *De :* Sravan K Lakkimsetti [mailto:[email protected] >> >>> <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>] >> >>> *Envoyé :* vendredi 10 mars 2017 11:33 >> >>> *À :* [email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> [email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> [email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> [email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> [email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>>; Grégoire DUPE >> >>> <[email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>>; >> >>> [email protected] <mailto:[email protected]> >> >>> <mailto:[email protected] <mailto:[email protected]>>; >> >>> [email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> [email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> [email protected] >> >>> <mailto:[email protected]><mailto:[email protected] >> >>> <mailto:[email protected]>>; >> >>> Frederic Gurr <[email protected] >> >>> <mailto:[email protected]> >> >>> <mailto:[email protected] >> >>> <mailto:[email protected]>>> >> >>> *Objet :* Problems with Simrel contribution >> >>> >> >>> Hi, >> >>> >> >>> I am doing simrel contribution for 4.7 M6 for platform and >> >>> equinox. During this process. I found that the >> >>> following projects are not compatible anymore. I have disabled >> >>> these projects with my contribution. My request is >> >>> to re-enable them during your contribution to 4.7 M6. >> >>> >> >>> The projects that were disabled. >> >>> >> >>> 1. EclEmma >> >>> 2. ECP >> >>> 3. EMF CDO >> >>> 4. EMF COMPARE >> >>> 5. EMF Parsley >> >>> 6. MoDisco >> >>> 7. Papyrus >> >>> 8. Sphinx >> >>> >> >>> Thanks and Regards, >> >>> >> >>> Sravan >> >>> >> >>> Sravan Kumar Lakkimsetti >> >>> >> >>> IBM India Pvt Ltd, >> >>> >> >>> Embassy Golf Links Business Park, D Block, >> >>> >> >>> Off Indiranagar-Kormangla Inner Ring Road, >> >>> >> >>> Bangalore - 560071, India >> >>> >> >>> Phone: 91-80-41776858 >> >>> >> >>> >> >>> >> >>> _______________________________________________ >> >>> cross-project-issues-dev mailing list >> >>> [email protected] >> >>> <mailto:[email protected]> >> >>> To change your delivery options, retrieve your password, or >> >>> unsubscribe from this list, visit >> >>> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev >> >>> <https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev> >> >> >> >> >> >> _______________________________________________ >> >> cross-project-issues-dev mailing list >> >> [email protected] >> >> <mailto:[email protected]> >> >> To change your delivery options, retrieve your password, or >> >> unsubscribe from this list, visit >> >> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev >> >> <https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev> >> >> >> > >> > >> > --- >> > This email has been checked for viruses by Avast antivirus software. >> > https://www.avast.com/antivirus <https://www.avast.com/antivirus> >> > >> > _______________________________________________ >> > cross-project-issues-dev mailing list >> > [email protected] >> > <mailto:[email protected]> >> > To change your delivery options, retrieve your password, or >> > unsubscribe from this list, visit >> > https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev >> > <https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev> >> > >> >> >> --- >> This email has been checked for viruses by Avast antivirus software. >> https://www.avast.com/antivirus <https://www.avast.com/antivirus> >> >> _______________________________________________ >> cross-project-issues-dev mailing list >> [email protected] >> <mailto:[email protected]> >> To change your delivery options, retrieve your password, or unsubscribe from >> this list, visit >> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev >> <https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev> >> >> >> >> >> _______________________________________________ >> cross-project-issues-dev mailing list >> [email protected] >> <mailto:[email protected]> >> To change your delivery options, retrieve your password, or unsubscribe from >> this list, visit >> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev >> <https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev>_______________________________________________ >> cross-project-issues-dev mailing list >> [email protected] >> <mailto:[email protected]> >> To change your delivery options, retrieve your password, or unsubscribe from >> this list, visit >> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev >> <https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev> >> >> >> >> >> _______________________________________________ >> cross-project-issues-dev mailing list >> [email protected] >> <mailto:[email protected]> >> To change your delivery options, retrieve your password, or unsubscribe from >> this list, visit >> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev >> <https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev> > > > <https://www.avast.com/antivirus> > This email has been checked for viruses by Avast antivirus software. > www.avast.com <https://www.avast.com/antivirus> > > _______________________________________________ > cross-project-issues-dev mailing list > [email protected] > <mailto:[email protected]> > To change your delivery options, retrieve your password, or unsubscribe from > this list, visit > https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev > <https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev> > > > > -- > -- > Trainer, Consultant and Developer > > vogella GmbH > Haindaalwisch 17a, 22395 Hamburg > Amtsgericht Hamburg: HRB 127058 > Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel > USt-IdNr.: DE284122352 > Tel (040) 78804360, Fax (032) 221739404, Email: [email protected] > <mailto:[email protected]>, Web: http://www.vogella.com > <http://www.vogella.com/>_______________________________________________ > cross-project-issues-dev mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe from > this list, visit > https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________ cross-project-issues-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
