Jonah, thanks for taking care of this. If we will revert it after RedDeer is pushed, I think it is safe to give it a try. Also, If Jetty should be built somewhere with a fix it might provide a space for updating all deps in all project, though, in quite late time.
Thanks On Wed, Jun 9, 2021 at 10:45 PM Jonah Graham <jo...@kichwacoders.com> wrote: > Hi Ondre/Nitin, > > https://git.eclipse.org/r/c/simrel/org.eclipse.simrel.build/+/181738 > decouples the reddeer contribution from webtools which means if you think > it is ok you can merge that so reddeer can be merged. > > Thanks > Jonah > > > > > ~~~ > Jonah Graham > Kichwa Coders > www.kichwacoders.com > > > On Wed, 9 Jun 2021 at 16:25, Jonah Graham <jo...@kichwacoders.com> wrote: > >> Hi Ondrej, >> >> AFAICT the problem is that WTP is also pulling in org.slf4j 2.0 from >> reddeer. >> >> 15:53:01 [0]Missing requirement: Jetty :: JNDI Naming 10.0.4 >> (org.eclipse.jetty.jndi 10.0.4) requires 'java.package; org.slf4j >> [2.0.0,3.0.0)' but it could not be found >> >> So because you are (correctly) removing slf4j 2.0, it is unintentionally >> breaking WTP. >> >> Nitin is working on fixing up the WTP contribution. I don't think there >> is actually anything wrong with reddeer's contribution, we just need a >> resolution of WTP first. >> >> I will push a patch that verifies the above in a moment. >> >> Thanks, >> Jonah >> >> >> >> >> ~~~ >> Jonah Graham >> Kichwa Coders >> www.kichwacoders.com >> >> >> On Wed, 9 Jun 2021 at 16:15, Ondrej Dockal <odoc...@redhat.com> wrote: >> >>> Unfortunately, I am still not able to pass aggregator validation, this >>> time it is jetty complaining about missing org.slf4j [2.0.0,3.0.0) as can >>> be seen in [1]. I am not really sure about what I can do about it from my >>> side. There is a reopened bugzilla [2] and PR on jetty project to handle >>> this bundle dep. range for org.slf4j, but who knows when it will be fixed. >>> >>> I am trying in a meantime to omit any bundles from my plugins in >>> release, not sure if that can help. >>> >>> [1]: >>> https://ci.eclipse.org/simrel/job/simrel.runaggregator.VALIDATE.gerrit/2274/console >>> [2]: https://bugs.eclipse.org/bugs/show_bug.cgi?id=573454 >>> >>> On Wed, Jun 9, 2021 at 6:47 PM Jonah Graham <jo...@kichwacoders.com> >>> wrote: >>> >>>> Ondrej, >>>> >>>> I think your analysis is correct. RAP tools publishes jetty to its p2 >>>> site, but does not include the slf4j so just happened to pick it up from >>>> Platform until they removed it, now it picks it up from Reddeer. >>>> >>>> Markus, >>>> >>>> Not sure what the issues with removing slf4j 2.0.0 alpha is. Do you >>>> mean that RAP references it in too many places? If you mean too many >>>> projects, then you might be right, but I hope not. Hopefully with rap, wtp, >>>> and reddeer making their update we can get rid of it from the 2021-06 >>>> release entirely. >>>> >>>> Nitin, >>>> >>>> I think the RC2 contribution of WTP only validated because Reddeer is >>>> still publishing slf4j 2.0. >>>> >>>> Jonah >>>> ~~~ >>>> Jonah Graham >>>> Kichwa Coders >>>> www.kichwacoders.com >>>> >>>> >>>> On Wed, 9 Jun 2021 at 10:55, Ondrej Dockal <odoc...@redhat.com> wrote: >>>> >>>>> Hi Folks, >>>>> >>>>> Gerrit aggregator validation job [1] is failing for me due to RAP >>>>> requiring jetty 10.0.3 and that transitively requires slf4j in 2.0.0 +, I >>>>> guess I have to wait for you to update jetty deps to make it work, right? >>>>> >>>>> [1]: >>>>> https://ci.eclipse.org/simrel/job/simrel.runaggregator.VALIDATE.gerrit/2247/ >>>>> >>>>> On Wed, Jun 9, 2021 at 4:50 PM Markus Knauer < >>>>> mkna...@eclipsesource.com> wrote: >>>>> >>>>>> Switching to Jetty 10.0.4 seems to be doable for RAP, especially >>>>>> because the Webtools team was so kind to give us access to their p2 >>>>>> repository for building. I will try that now. >>>>>> >>>>>> slf4j 2.0.0 is a different issue. It was required until today, and is >>>>>> now referenced in too many places. I am not sure if it will be possible >>>>>> to >>>>>> remove it in a quick and safe manner in a last build towards RC2. >>>>>> >>>>>> Thanks >>>>>> Markus >>>>>> >>>>>> On Wed, 9 Jun 2021 at 15:32, Jonah Graham <jo...@kichwacoders.com> >>>>>> wrote: >>>>>> >>>>>>> Hi folks, >>>>>>> >>>>>>> Eclipse Platform have successfully updated their contribution* >>>>>>> (Thanks Sravan, Thomas, Jetty team and anyone else who got this done >>>>>>> that I >>>>>>> don't know about!) *to SimRel to their RC2a build and that means >>>>>>> that Eclipse Platform now no longer contributes the alpha 2.0.0 version. >>>>>>> >>>>>>> However other projects still are contributing the bundle to simrel >>>>>>> because they are republishing parts or all of Platform RC2 or earlier or >>>>>>> jetty 10 from other sources. >>>>>>> >>>>>>> Can both *reddeer *and *rap *projects look at their contribution to >>>>>>> ensure that they are not contributing slf4j 2.0.0 alpha to the simrel >>>>>>> please. >>>>>>> >>>>>>> As Platform have updated to Jetty 10.0.4, I also see that *rap* has >>>>>>> Jetty 10.0.3 contributed to simrel and *webtools* has 10.0.2 >>>>>>> contributed to webtools. *All three versions* are in the simrel >>>>>>> output repo! >>>>>>> >>>>>>> Thank you, >>>>>>> Jonah >>>>>>> >>>>>>> ~~~ >>>>>>> Jonah Graham >>>>>>> Kichwa Coders >>>>>>> www.kichwacoders.com >>>>>>> _______________________________________________ >>>>>>> cross-project-issues-dev mailing list >>>>>>> cross-project-issues-dev@eclipse.org >>>>>>> To unsubscribe from this list, visit >>>>>>> https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev >>>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> cross-project-issues-dev mailing list >>>>>> cross-project-issues-dev@eclipse.org >>>>>> To unsubscribe from this list, visit >>>>>> https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev >>>>>> >>>>> _______________________________________________ >>>>> cross-project-issues-dev mailing list >>>>> cross-project-issues-dev@eclipse.org >>>>> To unsubscribe from this list, visit >>>>> https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev >>>>> >>>> _______________________________________________ >>>> cross-project-issues-dev mailing list >>>> cross-project-issues-dev@eclipse.org >>>> To unsubscribe from this list, visit >>>> https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev >>>> >>> _______________________________________________ >>> cross-project-issues-dev mailing list >>> cross-project-issues-dev@eclipse.org >>> To unsubscribe from this list, visit >>> https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev >>> >> _______________________________________________ > cross-project-issues-dev mailing list > cross-project-issues-dev@eclipse.org > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev >
_______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
