I committed the second two, but the change to configure.ac didn't work
for me. I found an example online of using a fallback with nested
PKG_CHECK_MODULES calls, so I did that, and it works, so I committed
that, too.
On 2020-08-09 17:40, Kevin Zheng wrote:
On 8/9/20 1:08 PM, Preston Crow wrote:
In configure.ac, it is looking python2 instead of python-2.7. On my
system it fails to detect with python2, but with a check for python-2.7,
it works. I'm not an expert on autoconf, so I don't know if there's an
easy way to check for either. (Of course, moving to python 3 would make
all kinds of sense, but that's another topic.)
This seems to have something to do with the pkg-config name for your
Python 2 installation. pkg-config can be instructed to check both by
changing [python2] to [python2 python-2.7].
Enough things have changed that replacing python2 with python3 will get
you a working build with Python 3. It's the scripts that still need to
be converted to Python 3.
In common/init.c, things break badly if someone adds a field in the
middle of include/global.h. This can easily be fixed by assigning
specific field names, though that would move us up to a minimum of C99.
The code is already C99; that's fine. Patch welcome.
With gcc 10, you get multiple definition errors on shutdown_flag. This
should be declared extern in the .h and also declared in one C file.
Patch welcome here; it's only not already there because I don't think my
Clang warns about the same issue?
I'm happy to push commits for the second two issues, but I don't trust
that my fix for the first one wouldn't break things for other people.
(I'm not sure if I have permission to push, though.)
If not, a patch to the mailing list (here) is welcome.
_______________________________________________
crossfire mailing list
crossfire@metalforge.org
http://mailman.metalforge.org/mailman/listinfo/crossfire
