On 01/18/2016 11:04 PM, Phil Sutter wrote:
> On Tue, Jan 12, 2016 at 12:08:02PM +0200, Cristian Stoica wrote:
...
>> - *src_sg = NULL; /* default to no input */
>> - *dst_sg = NULL; /* default to ignore output */
>> -
>
> This does not look correct to me. The purpose of those is to ensure
> *src_sg and *dst_sg are initialized. Otherwise if src or dst are NULL
> (which matches the situation of "NULL input or output" as you state),
> they are left uninitialized by this function.
> Do you have an actual use case where this bites you?
The use-case I'm thinking is one where get_userbuf is called knowing upfront
that
only one of src or dst are of interest, skipping work completely on the other
buffer.
Of course, I can call get_userbuf with both output scatterlists and ignore one
of
them. But I would add more flexibility to this function if it is possible.
For example:
ret = get_userbuf(ses_ptr, src, len, NULL, 0, task, mm, &src_sg, NULL);
^^^^ ^ ^^^^
The current implementation does not permit output &scatterlist to be NULL even
though
it allows for input buffer to be NULL.
If this patch is incorrect for all cases, I'm thinking of some alternative
implementations:
- the callers set the scatterlists with NULL before calling get_userbuf
- get_userbuf checks for non-NULL output scatterlists before writing default
values to them
Cristian S.
_______________________________________________
Cryptodev-linux-devel mailing list
Cryptodev-linux-devel@gna.org
https://mail.gna.org/listinfo/cryptodev-linux-devel
