Thanks for suggestions. The punctuation was not an issue. Doc8 complains if the too long line contains whitespaces and is followed by another bullet list entry (if --allow-long-titles option is off, it will fail regardless of the entry order). Breaking the line in the middle of the cross-reference solves the problem for now.
I fixed it in a separate commit which will hopefully solve the codecov problem too. I'll fill a bug report @doc8 later on. -- Krzysiek -----Original Message----- From: Cryptography-dev <cryptography-dev-bounces+k.jackiewicz=samsung....@python.org> On Behalf Of Paul Kehrer Sent: Thursday, July 29, 2021 8:30 PM To: cryptography-dev@python.org Subject: Re: [Cryptography-dev] Problems with codecov & doc8 Unfortunately codecov commonly has issues with proper reporting. It looks like in your case the mac builders weren't successfully submitting coverage. We'd love to migrate to a more functional system, but codecov and coveralls both have...issues. We won't let that block review, although pushing a few extra commits or rebasing can resolve it since it's an inconsistent problem with codecov. As for doc8, feel free to modify the offending line. Moving the trailing punctuation (which should be a period) will likely resolve it. It's probably worth filing a bug with doc8 around this if you can come up with a small reproducer since I believe we've seen this issue in the past. -Paul On Thu, Jul 29, 2021 at 10:38 AM Krzysztof Jackiewicz/Security (PLT) /SRPOL/Engineer/삼성전자 <k.jackiew...@samsung.com> wrote: > > Hi, > > Project codecov and doc8 checks for my recent PR > (https://protect2.fireeye.com/v1/url?k=5f977e63-000c46ba-5f96f52c-0cc4 > 7a3356b2-e04c6f618d9a0339&q=1&e=74ac4513-e918-4f02-99f7-77762aafea3a&u=https%3A%2F%2Fgithub.com%2Fpyca%2Fcryptography%2Fpull%2F6181) > have failed and I can't find the way to make them pass. > > IMHO the codecov fail is unrelated to the PR. It looks like a problem > with testing environment. I ran pytest with coverage report before and > after my changes and the coverage ratio was unchanged. Is it possible > to reproduce the codecov check locally somehow? > > The doc8 check fails because of too long line in CHANGELOG.rst but the > line was not changed in the PR. I noticed that doc8 complains only if > the offending line is not the last one on the list. I could trick it > by putting the KBKDFCMAC entry before the offending line but I don't > think it's the way to go. > > Please advise, > > Thanks > > -- > Krzysiek > > _______________________________________________ > Cryptography-dev mailing list > Cryptography-dev@python.org > https://mail.python.org/mailman/listinfo/cryptography-dev _______________________________________________ Cryptography-dev mailing list Cryptography-dev@python.org https://mail.python.org/mailman/listinfo/cryptography-dev _______________________________________________ Cryptography-dev mailing list Cryptography-dev@python.org https://mail.python.org/mailman/listinfo/cryptography-dev
