On Tue, Nov 26, 2002 at 02:45:03PM -0500, Wei Dai wrote: > On Sun, Nov 24, 2002 at 08:44:53PM -0600, Rickey Braddam wrote: > > and in strciphr.cpp in > > byte AdditiveCipherTemplate<S>::GenerateByte() > > return KeystreamBufferEnd()[-m_leftOver--]; > > it is negated then decremented. > > > > Since the result remains unsigned, m_leftOver just gets decremented, doesn't > > it? That doesn't look like what you intended... > > Thanks for point this out. It should work as long as pointers and unsigned > int have the same size, but may not work otherwise. I'll put in a fix for > it.
BTW, the fix is to change the line to return *(KeystreamBufferEnd()-m_leftOver--);
