Am 30.06.2015 um 01:11 schrieb Jeffrey Walton: > Below is Alex's patch. I think it should it taken after some testing. > > We need to test on 32-bit and 64-bit Windows, but I don't have those > environments for testing. (I can test on other platforms, like Linux > BSD and OS X to ensure no cross pollination or unintended consequences). > > QUESTION: Are there any objections to taking it? No. At least I see none. > > QUESTION: Can anyone assist in testing the change below? Not that much need of tests for this one. (IMO)
Visual Studio will compile just fine, as this change doesn't affect it's code. (#1 Windows checked) MingW / Cygwin should also work, as the person having us provided with this patch surely made sure that this fixes the issue on his end. The patch seems very un-intrusive (only affecting x64 Cygwin) and the changed typedef shouldn't change anything except for adapting to the fact that (for some obscure reason) 64-bit pointers perform better / are required on 64-bit builds. (#2 Windows checked) The only really interesting point about this patch would be: What actually happens if one tries to compile / run the old code with GCC in 64-bit? Raising the question if we should remove the defined(__CYGWIN__) from the patch. (needs some testing though) BR JPM > > Jeff > > diff --git a/osrng.h b/osrng.h > index ae07d05..c2dba27 100644 > --- a/osrng.h > +++ b/osrng.h > @@ -32,6 +32,8 @@ class CRYPTOPP_DLL MicrosoftCryptoProvider > ~MicrosoftCryptoProvider(); > #if defined(_WIN64) > typedef unsigned __int64 ProviderHandle; // type HCRYPTPROV, > avoid #include <windows.h> > +#elif defined(__CYGWIN__) && defined(__x86_64__) > + typedef unsigned long long ProviderHandle; > #else > typedef unsigned long ProviderHandle; > #endif > > -- > -- > You received this message because you are subscribed to the "Crypto++ > Users" Google Group. > To unsubscribe, send an email to > [email protected]. > More information about Crypto++ and this group is available at > http://www.cryptopp.com. > --- > You received this message because you are subscribed to the Google > Groups "Crypto++ Users" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected] > <mailto:[email protected]>. > For more options, visit https://groups.google.com/d/optout. -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
smime.p7s
Description: S/MIME Cryptographic Signature
