> On Sunday, October 18, 2015 at 8:23:32 PM UTC-4, Jeffrey Walton wrote: >> >> >> The only thing left to do with it is >>> a) verify that I actually did the opcode right [1] >>> >> >> By the way, I think RDSEED detection code should look similar to the >> following. Also see the discussion of Highest Function level at >> https://en.wikipedia.org/wiki/CPUID#EAX.3D0:_Highest_Function_Parameter >> ... >> > > Here's what the RDSEED detection code ended up being. AMD does not offer > RDSEED, so we need to filter the call for Intel processors. > > I think the run-time detection code should be in cpu.h and cpu.cpp and not > in rdrand.h and rdrand.cpp. There is already AMD / Intel and feature > detection code and our code would fit perfectly there. The outside (of > cpu.XXX) could access via HasRdRand() and HasRdSeed(). >
Yes, agreed. We have to be careful of versioning requirements at the moment, so we can't break CPU.{h|cpp}. That will be one of the first changes made when we can break things. Jeff -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to cryptopp-users-unsubscr...@googlegroups.com. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.