On Friday, 1 June 2018 02:21:43 UTC+1, Jeffrey Walton wrote: > > > > On Thursday, May 31, 2018 at 6:03:58 AM UTC-4, Andrew Marlow wrote: >> >> Hello everyone, >> >> I just spotted an issue with cryptopp which was spotted during static >> code analysis of my own code which uses both zlib and cryptopp. It was very >> mysterious. It was behaving as if the zlib header zlib.h was not being >> included. But everything compiled just fine. It turned out that my script >> for running clang-tidy was generating a JSON file that mentioned the >> cryyptopp header directory before mentioning the header directory for zlib. >> So my #include statement (#include <zlib.h>) picked up the one from >> cryptopp instead of picking up the one from zlib. >> >> Please rename the cryptopp header file zlib.h to make it obvious that it >> is not the zlib header. I see the crypto one is for a collection of classes >> that wrap zlib functionality in C++ classes. So perhaps it could be called >> zlib_classes.h. >> > > I believe the way to avoid it is to #include <cryptopp/zlib.h>. The > include guards certainly are different so it should not pose a problem. >
Well, that would be one way, except that the cryptopp version of zlib.h does not live in a directory with that name. The files validat0.cpp and zlib.cpp refer to just the leaf name. If we are going to keep the filename then can the header files please be put into a directory such as include/cryptopp, then I could change my code in the manner you suggest. The files validat0.cpp and zlib.cpp would also have to change for the same reason. > > Also see https://stackoverflow.com/q/5168242/608639 . > > Jeff > -- You received this message because you are subscribed to "Crypto++ Users". More information about Crypto++ and this group is available at http://www.cryptopp.com and http://groups.google.com/forum/#!forum/cryptopp-users. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
