On Fri, May 17, 2013 at 10:21 AM, Lars Ellenberg <lars.ellenb...@linbit.com> wrote: > Correct. Though for later tests (correct uid/gid transfer, picking up > only uid/gid changes and so on) root will be required obviously.
It would be really useful if tests that require root could be skipped automatically when running as non-root. For limiting potential destruction, I'd really rather run tests as non-root first and make sure all the non-root-possible cases pass before doing anything as root. It would also be nice if the test input and output were logically separate. When I write test suites, I mkstmp in /tmp and write all files there. That way, each run is unique, I can keep and compare the output of multiple runs during debugging, and cleanup is trivial. Also, it can sometimes speed up test suites when /tmp is running on tmpfs... I don't have experience with prove and TAP so I don't know how easy either of those ideas would be. > That cfg file should have been generated, not committed as is. > Oversight on my part, I know about that. If I understand you correctly, that's something that would be fixed by my mkstemp in /tmp -- there would never be a generated file to accidentally check in within the git checkout. > BTW, you can also do > CSYNC2_DATABASE=mysql://csync2:csync2@192.168.122.1/ prove > CSYNC2_DATABASE=pgsql://csync2:csync2@192.168.122.1/ prove > To check those backends as well. Yeah, saw that, thanks! I'll eventually test with pgsql because that's how I'll end up deploying, since I'll need it for scale. > What's still going in before the final release: > - there was some patch here recently that changed the hardcoded > timeout/retry locking behaviour, I think that should go in > - if you/someoen gets that "ssh tunnel" mode done in time, > that is definetely in, and if that takes a couple of weeks > extra, that's ok. Like I suspect is true for you, my available time is a bit unpredictable. I'm first writing some additional tests to cover my use case, and which I can contribute when I'm done. Then at whatever time I start making good progress on the ssh tunnel mode, I'll let you know and you can decide what schedule effect it might have. _______________________________________________ Csync2 mailing list Csync2@lists.linbit.com http://lists.linbit.com/mailman/listinfo/csync2
