LGTM, great work Pei! Cheers, Chris
On Nov 2, 2012, at 12:22 PM, Chen, Pei wrote: > Hi Chris, > Thanks for confirming. The Apache release audit tool (RAT) has been added in > now with 0 unapproved licenses. > However, I had to add the below excludes in order for it to pass cleanly. > Please let us know if you have any concerns/issues. > I think we can enable apache-rat:check in the Jenkins build after this > release so it'll be caught and alert those who may have forgotten to include > the headers. > > <excludes> > <!-- File generated by maven-release-plugin --> > <exclude>release.properties</exclude> > <!-- Eclipse launch files --> > <exclude>**/*.launch</exclude> > <!-- Exclude target and eclipse files > The default RAT ignoreEclipse doesn't work > if there is a submodule that is commented out > So excluding it explictly here --> > <exclude>**/.classpath</exclude> > <exclude>**/.project</exclude> > <exclude>**/.settings/**</exclude> > > > <exclude>**/target/**</exclude> > <exclude>**/MANIFEST.MF</exclude> > <!-- Exclude bin/model resources --> > <exclude>**/resources/models/**</exclude> > > <exclude>**/src/main/resources/**</exclude> > <exclude>**/src/test/resources/**</exclude> > <exclude>**/META-INF/org.uimafit/types.txt</exclude> > > <!-- Exclude test data files --> > <exclude>**/data/test/**</exclude> > <exclude>**/data/**</exclude> > <exclude>**/output/**</exclude> > <exclude>**/sample_note.txt</exclude> > > > </excludes> > <numUnapprovedLicenses>0</numUnapprovedLicenses> > > Thanks, > Pei > >> -----Original Message----- >> From: Mattmann, Chris A (388J) [mailto:[email protected]] >> Sent: Thursday, November 01, 2012 8:15 PM >> To: <[email protected]> >> Subject: Re: Apache RAT plugin >> >> Hi Pei, >> >> Nope no formal place so feel free to simply state that 'it has passed RAT >> checks' >> and then rely on the mentors to verify this -- should they decide to build >> it. >> Otherwise, the standard place in the target folder is fine by me. >> >> Cheers, >> Chris >> >> On Nov 1, 2012, at 3:23 PM, Chen, Pei wrote: >> >>> Hi Mentors, >>> Is there a preferred format or place for the rat reports before voting? >>> By default, mvn apache-rat:check just places the rat.txt in the target >>> folder. >>> >>> Thanks, >>> Pei >
