Yang, 

Yes, you make a good point.  If I modify the method to also take the resolved 
IP address of the hostname as an argument and test either the hostname or the 
IP address against each no proxy host string, that should solve the problem, 
right?  Do you have any other concerns?

The case I was solving involved accessing a website by it's IP address, which 
probably isn't as useful generally as the case you pointed out.

Thanks,
Mark

-----Original Message-----
From: curl-library-boun...@cool.haxx.se 
[mailto:curl-library-boun...@cool.haxx.se] On Behalf Of Yang Tse
Sent: Wednesday, November 11, 2009 9:18 PM
To: libcurl development
Subject: Re: IP address support for no proxy feature

2009/11/12, Salisbury, Mark wrote:

> Here's how I'd propose updating it:
>
> .IP CURLOPT_NOPROXY
> Pass a pointer to a zero terminated string. This should be a comma-separated
> list of hosts which do not use a proxy, if one is specified.  To disable the
> proxy, set a single * character.  Each name in this list is matched as either
> a domain which contains the hostname, the hostname itself, or an IP address
> range. For example, local.com would match local.com, local.com:80, and
> www.local.com, but not www.notlocal.com.  192.* will match all hosts
> beginning with 192, like 192.168.1.100.  It will not match 10.10.10.192.
> (Added in 7.19.4, updated to support IP address ranges in 7.19.8)

Ok, the patch does not bring the capability that the RE seemed to
imply and it doesn't bring the capabilities that the modified
documentation for CURLOPT_NOPROXY state.

Even with the patch applied if a destination URL is specified with a
format such as 'host1.local.com' while --noproxy specifies the IP
address of host1.local.com the request will go through the proxy,
ignoring the --noproxy setting.

What the patch brings is the capability of filtering using an IP
subnet notation those URL's which have been given using the IP address
of the host.

Given this, in order to be committed or the code part of the patch is
reworked to fullfill the description, or the contrary is done.

-- 
-=[Yang]=-
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html

Reply via email to