On Wed, 2011-07-13 at 05:52 +0800, Daniel Stenberg wrote: > Great! Glad to see this. Daniel, Thanks for reviewing the patch. > I've not actually ran it, but I built it fine on Linux without complaints. > I'm > looking forward to seeing some tests for this. Also, this new feature needs a > word or two in the documentation. I am working on the tests for this and will send a patch in a few days. > > Two words about your changes to include/curl/curl.h: > > 1 - that's a public header for user applications so it cannot use #ifdef > USE_NTLM_SSO. Error codes should be independent of build features anyway > so you can just provide them unconditionally. > > 2 - speaking of said error codes, it seems CURLE_NTLM_AUTH_FAILED is very > specific for exactly this authentication method without any real need. > Couldn't just the existing CURLE_REMOTE_ACCESS_DENIED or similar be used? CURLE_REMOTE_ACCESS_DENIED make more sense here. Initially I want to see the result through the error messages when I am doing nagetive test. I will undo those error codes.
Thanks, Mandy ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
