On Tue, 2011-07-19 at 05:56 +0800, Daniel Stenberg wrote: > On Mon, 18 Jul 2011, Wu, Mandy wrote: > > > I have removed the NTLM_AUTH specific error codes, and add DEBUGBUILD > > support for running test cases. Here is the updated patch. Please help > > review it. The patch for adding test cases for it will be sent in another > > mail. > > Lovely! I liked them so much I decided to merge and push both your patches > (only very slightly amended by me). > > Get the latest git version now and see if there's anything left to polish > (and > of course check to see that no builds go bananas with the new code present). > I > did run the new test 2005 successfully on my machine and it looks to be > exactly as I had envisioned it, I pulled the latest code, build, make, and everything works fine on me. Just observation, when curl is Not build with --enable-debug, test case 2005 will fail, due to libcurl goes to real ntlm_auth tool. I am thinking maybe we can enforce test case 2005 to be run with --enable-debug build by adding a 'unittest' feature, like below.
diff --git a/tests/data/test2005 b/tests/data/test2005 index 36fb535..b3649ac 100644 --- a/tests/data/test2005 +++ b/tests/data/test2005 @@ -56,6 +56,7 @@ Finally, this is the real page! <client> <features> NTLM_SSO +unittest </features> <server> http Thanks, Mandy ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
