Updated patch is attached. thanks, Bill -----Original Message----- From: curl-library [mailto:[email protected]] On Behalf Of Steve Holme Sent: Thursday, September 25, 2014 12:27 PM To: libcurl development Subject: RE: [PATCH] smtps with openssl
On Wed, 17 Sep 2014, Nagel, Bill wrote: > This patch fixes the "SSL3_WRITE_PENDING: bad write retry" error that > sometimes occurs when sending an email over smtps with openssl. > openssl appears to require the same pointer on a write that follows a > retry (CURLE_AGAIN). Just a couple of niggles whilst I mull the patch over: * You don't test for OOM on the strdup() operation. Admitidly the original code didn't but we should return CURLE_OUT_OF_MEMORY if it does fail. * I think you have introduced a memory leak if Curl_write() fails. Kind Regards Steve ------------------------------------------------------------------- List admin: http://cp.mcafee.com/d/2DRPowcz9J5x55NNCWb9KVJeXxEVuoouvsdFT78EIIEIc6QXK6zBVxxVZUSztAsOqem7Am3py6Avf1kORGOxfBPsORGOxfBPreIcc9IfZvC7XLzD-LsKCCeuUsOqehRXYJteOaaJQk-l3PWApmU6CQjqpK_3AmkXzDS1OpKVI07qJj-9W7x_k_3VkDxYGjB1SKmryunfAgzIiNKPsjOVYy4tymbAaJMJZ0lqJj-9W7x_kYSOMeKr1oQAq83iS5x04ygndbFEwEHdqxEwciCjd45lLxixVJCVIZ1VWc13 Etiquette: http://cp.mcafee.com/d/5fHCNAq6wUqdEI8EKecThpdTdFTsd7bP33PXxJeUV55BB5xwSDtMQsLccffL6QrIzCjhOMYyMrcgQzVUaCmJmk9YKrCmJmk9YKrpRxxxdx_HYM_tYs_RXBQQNPT3CjhOeLvBHFShhlKyDOEuvkzaT0QSCrjdTUsyODss-MejdTdw0XdNfUDEu7ZjY4Y-sxpLVP_wsrIT4YKv8x7oByV2Hsbvg5mHk_yuxUvRfdII3HCMmd96y0QJxog18A5PiWq8aaPmEq834FAPh1lrUkEurpKrUKey0ZTh ________________________________ This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments.
ssl_write2.patch
Description: ssl_write2.patch
------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
