On Wed, 17 Sep 2014, Nagel, Bill wrote:
> This patch fixes the "SSL3_WRITE_PENDING: bad write retry" error that > sometimes occurs when sending an email over smtps with openssl. > openssl appears to require the same pointer on a write that follows a > retry (CURLE_AGAIN). Just a couple of niggles whilst I mull the patch over: * You don't test for OOM on the strdup() operation. Admitidly the original code didn't but we should return CURLE_OUT_OF_MEMORY if it does fail. * I think you have introduced a memory leak if Curl_write() fails. Kind Regards Steve ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
