Title: RE: Using ftpupload.c returns a directory listing in HTML format
Thanks Patrick!
I tried your way, at least I get another error message now!
"curl_easy_perform ()  failed: Upload failed (at start/before it took off)"
So how to rewrite my URLs so cURL accepts them. I begin to a bit desperate now, are there no debug/error printf() possible? ( I use -Wall ...)
Nils, wondering if the example worked to start with??

Den 2015-08-13 kl. 01:21, skrev Patrick Monnerat:

Nils Soderman wrote:

Please don't top-post: http://curl.haxx.se/mail/etiquette.html#Do_Not_Top_Post

> My exact version of ftpupload.c is attached. Where is the problem hiding?

Your remote URL is a directory: it's thus impossible to overwrite it with a file. As the error says, this is a bad URL for uploading.
In other words, you forgot to name the upload destination file.

You probably have to change:

curl_easy_setopt(curl,CURLOPT_URL, REMOTE_URL);

into

curl_easy_setopt(curl,CURLOPT_URL, REMOTE_URL "/" UPLOAD_FILE_AS);

Patrick



-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html


pi@VallrunElmeter ~/Counter $ sudo ./ftpupload 
Local file size: 99 bytes.
curl_easy_perform ()  failed: Upload failed (at start/before it took off)


#define LOCAL_FILE      "/home/pi/Counter/temp/ws_data.txt"
#define UPLOAD_FILE_AS  "ws_data2.txt"
#define REMOTE_URL      "ftp://192.168.0.151/backup/ftptest/"; UPLOAD_FILE_AS
#define RENAME_FILE_TO  "ws_data3.txt"
/***************************************************************************
 *                                  _   _ ____  _
 *  Project                     ___| | | |  _ \| |
 *                             / __| | | | |_) | |
 *                            | (__| |_| |  _ <| |___
 *                             \___|\___/|_| \_\_____|
 *
 * Copyright (C) 1998 - 2011, Daniel Stenberg, <[email protected]>, et al.
 *
 * This software is licensed as described in the file COPYING, which
 * you should have received as part of this distribution. The terms
 * are also available at http://curl.haxx.se/docs/copyright.html.
 *
 * You may opt to use, copy, modify, merge, publish, distribute and/or sell
 * copies of the Software, and permit persons to whom the Software is
 * furnished to do so, under the terms of the COPYING file.
 *
 * This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
 * KIND, either express or implied.
 *
 ***************************************************************************/
#include <stdio.h>
#include <string.h>
 
#include <curl/curl.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <errno.h>
#ifdef WIN32
#include <io.h>
#else
#include <unistd.h>
#endif
 
/* <DESC>
 * Performs an FTP upload and renames the file just after a successful
 * transfer.
 * </DESC>
 */ 
 
#define LOCAL_FILE      "/home/pi/Counter/temp/ws_data.txt"
#define UPLOAD_FILE_AS  "ws_data2.txt"
#define REMOTE_URL      "ftp://192.168.0.151/backup/ftptest/"; UPLOAD_FILE_AS
#define RENAME_FILE_TO  "ws_data3.txt"
 
/* NOTE: if you want this example to work on Windows with libcurl as a
   DLL, you MUST also provide a read callback with CURLOPT_READFUNCTION.
   Failing to do so will give you a crash since a DLL may not use the
   variable's memory when passed in to it from an app like this. */ 
static size_t read_callback ( void *ptr, size_t size, size_t nmemb, void 
*stream ) 
{
  curl_off_t nread;
  /* in real-world cases, this would probably get this data differently
     as this fread ()  stuff is exactly what the library already would do
     by default internally */ 
  size_t retcode = fread ( ptr, size, nmemb, stream );
 
  nread =  ( curl_off_t ) retcode;
 
  fprintf ( stderr, "*** We read %" CURL_FORMAT_CURL_OFF_T
          " bytes from file\n", nread );
  return retcode;
}
 
int main ( void ) 
{
  CURL *curl;
  CURLcode res;
  FILE *hd_src;
  struct stat file_info;
  curl_off_t fsize;
 
  struct curl_slist *headerlist = NULL;
  static const char buf_1 []  = "RNFR " UPLOAD_FILE_AS;
  static const char buf_2 []  = "RNTO " RENAME_FILE_TO;
 
  /* get the file size of the local file */ 
  if ( stat ( LOCAL_FILE, &file_info )  )  
  {
    printf ( "Couldnt open '%s': %s\n", LOCAL_FILE, strerror ( errno )  );
    return 1;
  };
  fsize =  ( curl_off_t ) file_info.st_size;
 
  printf ( "Local file size: %" CURL_FORMAT_CURL_OFF_T " bytes.\n", fsize );
 
  /* get a FILE * of the same file */ 
//hd_src = fopen ( LOCAL_FILE, "rb" );
  hd_src = fopen ( LOCAL_FILE, "r" );
   if ( hd_src < 0  )  
  {
    printf ( "Couldnt open '%s': %s\n", LOCAL_FILE, strerror ( errno )  );
    return 1;
  };

  /* In windows, this will init the winsock stuff */ 
  curl_global_init ( CURL_GLOBAL_ALL );
 
  /* get a curl handle */ 
  curl = curl_easy_init ();
  if ( curl )  
  {
    /* build a list of commands to pass to libcurl */ 
    headerlist = curl_slist_append ( headerlist, buf_1 );
    headerlist = curl_slist_append ( headerlist, buf_2 );
 
    /* we want to use our own read function */ 
    curl_easy_setopt ( curl, CURLOPT_READFUNCTION, read_callback );
 
    /* enable uploading */ 
    curl_easy_setopt ( curl, CURLOPT_UPLOAD, 1L );
 
    /* specify target */ 
    curl_easy_setopt( curl, CURLOPT_URL, REMOTE_URL );
 
    /* pass in that last of FTP commands to run after the transfer */ 
    curl_easy_setopt ( curl, CURLOPT_POSTQUOTE, headerlist );
 
    /* now specify which file to upload */ 
    curl_easy_setopt ( curl, CURLOPT_READDATA, hd_src );
 
    /* Set the size of the file to upload  ( optional ) .  If you give a *_LARGE
       option you MUST make sure that the type of the passed-in argument is a
       curl_off_t. If you use CURLOPT_INFILESIZE  ( without _LARGE )  you must
       make sure that to pass in a type 'long' argument. */ 
    curl_easy_setopt ( curl, CURLOPT_INFILESIZE_LARGE,
                      ( curl_off_t ) fsize );
 
    /* Now run off and do what you've been told! */ 
    res = curl_easy_perform ( curl );
    /* Check for errors */ 
    if ( res != CURLE_OK ) 
      fprintf ( stderr, "curl_easy_perform ()  failed: %s\n",
              curl_easy_strerror ( res )  );
 
    /* clean up the FTP commands list */ 
    curl_slist_free_all  ( headerlist );
 
    /* always cleanup */ 
    curl_easy_cleanup ( curl );
  };
  fclose ( hd_src ); /* close the local file */ 
 
  curl_global_cleanup ();
  return 0;
};
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html

Reply via email to