On Fri, Oct 25, 2019 at 12:56:43 +0900, Ryota Ozaki wrote: > > @@ -72,7 +74,7 @@ serverconnect(const char *addr, unsigned short port) > > [...] > > + err(1, "setsockopt(SO_NOSIGPIPE)"); > > > > I'd just trim it down to "SO_NOSIGPIPE". > > > > + err(1, "open(%s)", path); > > > > Ditto. Just make it "%s". > > I prefer more informative messages. Why do you want to trim them?
Consider that from the user perspective. As a developer it's tempting to dump the implementation details, but which of the following is more readable to the user: $ ls foo ls: foo: No such file or directory or $ ls foo ls: stat(foo): No such file or directory -uwe
