On Fri, Oct 25, 2019 at 3:04 PM Michael van Elst <mlel...@serpens.de> wrote: > > ozaki.ry...@gmail.com (Ryota Ozaki) writes: > > >> @@ -72,7 +74,7 @@ serverconnect(const char *addr, unsigned short port) > >> + err(1, "setsockopt(SO_NOSIGPIPE)"); > >> + err(1, "open(%s)", path); > > >I prefer more informative messages. Why do you want to trim them? > > > Usually the error gives enough context, e.g. SO_NOSIGPIPE is a socket option > and telling that it's setsockopt failing is redundant and printing > an input file name is enough when the error identifies the operation > or the specific operation doesn't matter. > > But there is no rule for this, in particular when embedding filenames > where multiple operations are possible. Many people seem to prefer even > more verbose phrases like "Cannot open `%s'". Our code base has lots > of variants.
I think I'm affected by ping6 or something (it's just one of variants though). > > I personally would prefer error messages without special characters > so that you can grep them easily. :) Indeed. A type of annoying messages is that a phrase is separated into two (or more) lines to avoid the 80 character limit. That's quite anti-grep :-/ ozaki-r
