On Wed, May 20, 2020 at 1:43 PM Lucas Albuquerque Medeiros de Moura <
[email protected]> wrote:
> Wait, I think I missed something for these scenarios:
>
> network: {config: disabled}
> network: {config: disabled, version=1}
>
> We should not create the /etc/cloud/cloud.cfg.d/50-curtin-networking.cfg
> file for them ?
>
> I thought that they were valid cloudinit configs and we should propagate
> them. Right now, we are creating those files for these scenarios.
>
Yes, you're right; Looking back at my first comment we definitely want to
allow someone to write a config to disable cloud-init's networking.
Revising, I'd still like to keep all of the disabled scenarios in a single
test class file, and to help me separate them:
CurtinDisableNetworkRendering (net-meta --mode=disabled)
CurtinDisableCloudInitNetworking (network: {config: disabled})
CurtinDisableCloudInitNetworkingVersion1 (network: {config: disabled,
version=1}
--
> https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
> You are reviewing the proposed merge of
> ~lamoura/curtin:disable-networking-config into curtin:master.
>
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~curtin-dev
More help : https://help.launchpad.net/ListHelp
