dinukadesilva commented on a change in pull request #105:
URL:
https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668717509
##########
File path: src/lib/components/overlay/table-overlay-body.vue
##########
@@ -0,0 +1,143 @@
+<template>
Review comment:
@sannidhi09 Overlay means to show a kind of cover while the data is
loading. Just to show some blocks while the data is fetching. So, what are you
trying to do here? I guess you should move this to blocks.
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -1,11 +1,22 @@
<template>
- <TenantHome title="New Entity" :breadcrumb-links="breadcrumbLinks"
:errors="errors">
+ <TenantHome :title="this.parentId?'New Child Entity':'New Entity'"
:breadcrumb-links="breadcrumbLinks" :errors="errors">
Review comment:
Move this `title` to a computed function. Also, based on that the
breadcrumb texts also can be changed.
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -98,6 +109,13 @@ export default {
console.log("this.$route.params : ", this.$route.params);
return this.$route.params.clientId;
},
+ parentId(){
+ console.log("this.$route.params: ", this.$route.params);
+ if(this.$route.params.entityId !== undefined){
Review comment:
Just returning the `this.$route.params.entityId` is probably sufficient
here.
##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
ext: entity.ext
});
},
- async createEntity(obj, {clientId, entityId, name, description, type,
ownerId, fullText, binaryData}) {
- return await custosService.entities.createEntity({
Review comment:
Reinclude this return statement. It's been currently used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
