sannidhi09 commented on a change in pull request #105:
URL:
https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668755367
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -1,11 +1,22 @@
<template>
- <TenantHome title="New Entity" :breadcrumb-links="breadcrumbLinks"
:errors="errors">
+ <TenantHome :title="this.parentId?'New Child Entity':'New Entity'"
:breadcrumb-links="breadcrumbLinks" :errors="errors">
Review comment:
parentId is the computed function, the title is just the ternary
operation. I don't think it's better to add the title to the computed function
it uses unnecessary cache memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
