On Tue, 12 Oct 2010 03:11:43 +0000 (UTC) Steve Wills <[email protected]> mentioned:
> swills 2010-10-12 03:11:43 UTC > > FreeBSD ports repository > > Modified files: > devel Makefile > Added files: > devel/rubygem-pkg-config Makefile distinfo pkg-descr > Log: > - New port, a ruby gem for accessing pkg-config > > Submitted by: me (swills) > Approved by: pgollucci (mentor) Thanks for this port! Some things I noticed: 1. The WWW link points to the gem's page, not the homepage. The real homepage of the project is http://github.com/rcairo/pkg-config 2. It doesn't seem to depend on hoe, where this dependency come from? 3. We usually don't use hypens in the portname, and portlint wanrs about this afaik. It'd be better to name the port rubygem-pkgconfig 4. We usually prefer static pkg-plists instead of dynamic ones, especially in simple ones. Although it's totally a maintainer consideration, it is usually nice to have a plist you can search in with grep. 5. Although also a maintainer's choice I find it better to have non-gem versions of the libraries when they're available (like in this case). The reasons are that the non-gem version can be used both in application that supports gems and the one that doesn't, and it is possible to patch the port when it is needed. If in some time in future you will need to patch the contents on the port, it is impossible to do with gems. -- Stanislav Sedov ST4096-RIPE
pgpvQsCyhxaGS.pgp
Description: PGP signature
